fix struct type for number #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Sep 21, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 75.31% 75.31%
=======================================
Files 2 2
Lines 401 401
=======================================
Hits 302 302
Misses 99 99
☔ View full report in Codecov by Sentry. |
|
The docs failure is the new Documenter 1.0 release; I'll fix it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, JSON3 tries to parse a complex number to real type.
After the fix, the behavior is correct:
The JSON number type should correspond to the Julia Real number type.
Can we tag a patch version after the fix? Thanks!