use ProjectTo in Array addition

[oxinabox]

the reshape was a primative version of ProjectTo i think?

[mcabbott]

I see it has test_rrule(+, randn(3), randn(3,1), randn(3,1,1)) for this reshape, but maybe test Diagonal + Matrix or something?

[oxinabox]

I added

        test_rrule(+, randn(3,3), Diagonal(randn(3)), randn(3,3,1))
        test_rrule(+, randn(3,3), Diagonal(randn(3)), Symmetric(randn(3,3)))

and interestingly both fail.
So some debugging to do there

[mcabbott]

The bug is that this doesn't work:

julia> ProjectTo(Diagonal([1,2,3]))(randn(3,3,1))
ERROR: MethodError: no method matching (::ProjectTo{Diagonal, ... }}}}}}}})(::Array{Float64, 3})

julia> Diagonal(randn(3)) + randn(3,3,1)  # but this does
3×3×1 Array{Float64, 3}:

Fixed in JuliaDiff/ChainRulesCore.jl@a327838

[mcabbott]

The fix is part of JuliaDiff/ChainRulesCore.jl#446, BTW. Which I think should be merged.

[oxinabox]

Closing infavor of #783 because I can't be bothered rebasing