Consistency on using and qualified access
#2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added
Type: Maintenance
Skip Changelog
mortenpi
approved these changes
Mar 10, 2024
mortenpi
changed the title
using and qualified accessusing and qualified access
|
No, thats good to go! Thanks for the quick approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I tried to implement a consistent
usingapproach. As can be seen, this requires qualified access for most things, with some exceptions (to not unnecessarily produce code churn).My motivation for DocumenterEpub is that the code in HTMLWriter gets more readable/understandable (to me). This is of course a style question, so I can live with this being dropped.