Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating ics on grid for higher dimensions #99

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KalelR
Copy link
Contributor

@KalelR KalelR commented Oct 1, 2023

This is the code I used to deal with the problem we discussed in Issue #76. There, using basins_of_attraction in high (maybe >5?) dimensional-systems wouldn't run, because the algorithm would get stuck generating initial conditions. I explain the idea for my solution in Issue #76. It's probably not the most optimal way of solving the problem, but it works and is fast enough for my use-cases. Let me know if you think it's worth keeping it like this!

@codecov-commenter
Copy link

Codecov Report

Merging #99 (5eedc82) into main (8171746) will decrease coverage by 1.39%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   84.27%   82.89%   -1.39%     
==========================================
  Files          20       20              
  Lines        1151     1175      +24     
==========================================
+ Hits          970      974       +4     
- Misses        181      201      +20     
Files Coverage Δ
src/mapping/attractor_mapping.jl 63.63% <38.46%> (-17.32%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Datseris
Copy link
Member

Datseris commented Oct 8, 2023

I don't understand this PR. Can you please explain it? What are dimensions that are not "varying" ? What does this mean?

If someone calls basins_of_attraction(mapper, grid) then naturally all dimensions of the grid are varying, right? Or? This PR adds a function generate_ics_on_grid but doesn't reference this function anywhere, so I am not sure where or how this function would be used. Can you give a concrete example application?

@Datseris
Copy link
Member

Datseris commented Dec 4, 2023

bump @KalelR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants