Skip to content

Commit

Permalink
Print kernel info that requires hostcall (#642)
Browse files Browse the repository at this point in the history
  • Loading branch information
@pxl-th
pxl-th authored Jun 8, 2024
1 parent 4eeb92e commit 51921f7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "AMDGPU"
uuid = "21141c5a-9bdb-4563-92ae-f87d6854732e"
authors = ["Julian P Samaroo <jpsamaroo@jpsamaroo.me>", "Valentin Churavy <v.churavy@gmail.com>", "Anton Smirnov <tonysmn97@gmail.com>"]
version = "0.9.4"
version = "0.9.5"

[deps]
AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"
Expand Down
7 changes: 5 additions & 2 deletions src/compiler/codegen.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,13 @@ function hipcompile(@nospecialize(job::CompilerJob))
push!(global_hostcalls, gbl_name)
end
if !isempty(global_hostcalls)
@warn """Global hostcalls detected: $global_hostcalls.
@warn """Global hostcalls detected!
- Source: $(job.source)
- Hostcalls: $(global_hostcalls)
Use `AMDGPU.synchronize(; stop_hostcalls=false)` to synchronize and stop them.
Otherwise, performance might degrade if they keep running in the background.
""" maxlog=1
"""
end

if !isempty(globals)
Expand Down

2 comments on commit 51921f7

@pxl-th
Copy link
Collaborator Author

@pxl-th pxl-th commented on 51921f7 Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/108535

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.9.5 -m "<description of version>" 51921f75aa3a8af993a1ef6564c3f8adfd2ce9b6
git push origin v0.9.5

Please sign in to comment.