Area of 2D triangle can be negative

[knuesel]

For example:

julia> area(Point2f0[[0,0], [0,1], [1,1]])
-0.5f0

The relevant area method is here:

GeometryBasics.jl/src/triangulation.jl

Line 36 in 24d0ee5

function area(contour::AbstractVector{<:AbstractPoint{N,T}}) where {N,T}

I think there are two issues with this method:

1. It's the generic implementation for N dimensions, but it only works for N=2, as it assumes that cross exists and returns a scalar.
2. It's missing an abs call on the result.

Regarding the first point: there's already a specific method for N=3, and we can make one for N=2. Do we need a generic method for N>3?

[SimonDanisch]

Good point!

Do we need a generic method for N>3?

Probably not :D
Sounds like a good case for only specializing on 2 & 3 .

[knuesel]

Looks like the negative area was intentional:

GeometryBasics.jl/src/triangulation.jl

Line 127 in 24d0ee5

if 0 < area(contour)

Should we leave it like this (and document it)?

[SimonDanisch]

Oh, good catch :D Yeah, I guess the area function is mostly used inside GeometryBasics to figure out the winding order.

[knuesel]

I made the PR for the doc change, but it is a bit inconsistent to return a signed area for 2D an a positive area for 3D... Instead, we could have area return always a positive value, and a new oriented_area that returns a signed value for 2D and a vector for 3D?