Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area and MetaFree fixes #125

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Conversation

knuesel
Copy link
Contributor

@knuesel knuesel commented Jan 22, 2021

Some fixes for area following discussion in #121

  • area(::AbstractVector{AbstractPoint}}) is now documented
  • In particular, the doc says that a signed value is returned in the 2D case
  • Fixes for custom indices (OffsetArrays is added as a test dependency)
  • The 3D case now accepts vectors of any AbstractPoint{3} type (the 2D case already did)

There's also a broken area test for a vector of PointMeta{3}. I couldn't make it work because it needs zero(typeof(PointMeta(0,0,0; a=1)) and it's not clear how to implement that: How should we make the zero value of the metadata?

The PR includes a fix for a related bug: MetaFree(typeof(PointMeta(0,0,0; a=1)) used to return 3. Now it returns Point{3,Int64}, I think that's what was intended? (the fix isn't enough to make area work but I included it in the PR since it took me a while to figure out).

I also added Julia 1.3 in the CI test matrix, to avoid a repeat of #123 😊

@SimonDanisch
Copy link
Member

Thank you! :)

@SimonDanisch SimonDanisch merged commit d7fc448 into JuliaGeometry:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants