Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for
area
following discussion in #121area(::AbstractVector{AbstractPoint}})
is now documentedAbstractPoint{3}
type (the 2D case already did)There's also a broken
area
test for a vector ofPointMeta{3}
. I couldn't make it work because it needszero(typeof(PointMeta(0,0,0; a=1))
and it's not clear how to implement that: How should we make the zero value of the metadata?The PR includes a fix for a related bug:
MetaFree(typeof(PointMeta(0,0,0; a=1))
used to return3
. Now it returnsPoint{3,Int64}
, I think that's what was intended? (the fix isn't enough to makearea
work but I included it in the PR since it took me a while to figure out).I also added Julia 1.3 in the CI test matrix, to avoid a repeat of #123 😊