-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URLs in tests #36
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage ? 87.55%
=========================================
Files ? 1
Lines ? 249
Branches ? 0
=========================================
Hits ? 218
Misses ? 31
Partials ? 0 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
Coverage ? 87.55%
=========================================
Files ? 1
Lines ? 249
Branches ? 0
=========================================
Hits ? 218
Misses ? 31
Partials ? 0 Continue to review full report at Codecov.
|
GZip change looks good. We might just want to host the test files on GitHub or somewhere else. I think if DropBox gets weird requests it will block them. |
It might be worth pulling some files from here (look under "Slice timing correction" for the first actual DICOM file mention). This would probably be more ambitious than what you're going for now |
There are also some example DICOMS here: https://github.com/CIBC-Internal/Seg3DData/tree/cbe9eeabbfaeebdd6d05521ff31464e929491966/example_dicom |
Thanks for the links with the DICOM samples @sjkelly @Tokazama . The current tests use a few files from Barré's DICOM samples. That website was recently updated and the sample files are now on dropbox. I'm leaning towards the latter option of hosting them in a separate repository and I'll try doing that this week. Let me know if there's any other suggestions. We can extend the tests as well with more DICOM samples, but I would prefer getting the current tests dealt with first. |
Fixing what we have now and extending later sounds very reasonable. |
Sounds good. As an aside I have been working to make isosurface extraction work better with NRRD and DICOMs in Meshing.jl. I will add a DICOM example here soon: https://juliageometry.github.io/Meshing.jl/dev/examples/#NRRD-Data-1 |
Sounds good @sjkelly On my end, I made a github repository containing the DICOM files for testing. |
If there are no objections then I'll merge this by the end of the week. |
The tests have been failing recently because they need to download data but those URLs no longer work.
This PR updates the outdated URLs.
Other changes:
gunzip
withgzip