Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard malloc in compression filters #1152

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkitti
Copy link
Member

@mkitti mkitti commented May 27, 2024

Providing a length of 0 bytes to malloc could result in a valid pointer being generated. This is probably an error.

This pull request detects this condition and errors if detected. Also improves error messaging for failed allocation.

Co-authored-by: Mustafa Mohamad <mus-m@outlook.com>
@mkitti
Copy link
Member Author

mkitti commented May 30, 2024

Thanks for the fix. Also, should there be a way to just accept the formatter suggestions?

@musm
Copy link
Member

musm commented May 30, 2024

Do you mean to use https://github.com/julia-actions/julia-format

name: Format suggestions
on:
  pull_request:
    # this argument is not required if you don't use the `suggestion-label` input
    types: [ opened, reopened, synchronize, labeled, unlabeled ]
jobs:
  code-style:
    runs-on: ubuntu-latest
    steps:
      - uses: julia-actions/julia-format@v3
        with:
          version: '1' # Set `version` to '1.0.54' if you need to use JuliaFormatter.jl v1.0.54 (default: '1')
          suggestion-label: 'format-suggest' # leave this unset or empty to show suggestions for all PRs

@mkitti
Copy link
Member Author

mkitti commented May 30, 2024

Trying julia-format in #1153 , might merge that into a copy of this branch to see how it behaves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants