Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow manually specifying DPI #214

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simeonschaub
Copy link
Collaborator

@simeonschaub simeonschaub commented Feb 1, 2023

PDFs are currently always read with the default DPI of 72, which is not
particularly high. This allows manually specifying it using the dpi
keyword. Still needs a test, is there a good sample PDF document I could
use for this?

cc @timholy

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 73.93% // Head: 66.96% // Decreases project coverage by -6.97% ⚠️

Coverage data is based on head (1d11825) compared to base (079d62b).
Patch coverage: 92.85% of modified lines in pull request are covered.

❗ Current head 1d11825 differs from pull request most recent head 6fe954c. Consider uploading reports for the commit 6fe954c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   73.93%   66.96%   -6.97%     
==========================================
  Files           3        3              
  Lines         422      442      +20     
==========================================
- Hits          312      296      -16     
- Misses        110      146      +36     
Impacted Files Coverage Δ
src/libmagickwand.jl 67.20% <90.90%> (+0.10%) ⬆️
src/ImageMagick.jl 83.87% <100.00%> (+0.31%) ⬆️
src/precompile.jl 0.00% <0.00%> (-76.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy
Copy link
Member

timholy commented Feb 2, 2023

LGTM, thanks!

No strong feelings about a test file, other than it should be reasonably small and with unproblematic license. Wikimedia has a few, this one seems appropriate: https://commons.wikimedia.org/wiki/File:FLAT_-_What_is_Creative_Commons.pdf

PDFs are currently always read with the default DPI of 70, which is not
particularly high. This allows manually specifying it using the `dpi`
keyword. Still needs a test, is there a good sample PDF document I could
use for this?

cc @timholy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants