Bump compat on ImageMorphology and TiledIteration #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this will be a breaking release, it should be OK to remove or update tests.
|
The removed tests are all due to ImageMorphology, which I'm less familiar with. I locked the [compat] at 0.4 because it doesn't seem sensible to allow Images to give variable behavior depending on which version of ImageMorphology satisfies [compat] bounds. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 8 8
Lines 823 823
=======================================
Hits 721 721
Misses 102 102 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1011
Closes #1027
Since this will be a breaking release, it should be OK to remove
or update tests. But this part deserves scrutiny.