Remove old deprecations, add new ones #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
- Coverage 87.24% 84.07% -3.17%
==========================================
Files 6 4 -2
Lines 674 226 -448
==========================================
- Hits 588 190 -398
+ Misses 86 36 -50
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strips out the 0.25 deprecated code and adds the (minimal) deprecations for 0.26. There's a small issue with regards to what these deprecations should be (see JuliaImages/HistogramThresholding.jl#49), but the one added here is safe.
The process of removing the deprecated code from 0.25 revealed that the implementations in ImageContrastAdjustment are not drop-in replacements for the old code here. I decided to try to keep the old tests where possible; in cases where the test now fails, I marked it as
@test_broken. It's not obvious to me that we actually want to fix them, but given that this process uncovered JuliaImages/ImageContrastAdjustment.jl#58, it seemed useful to keep them for now. But we might end up deleting the entiretest/exposure.jlfile soon.One other related issue is that ImageContastAdjustment does not support alpha channels; again, it's unclear whether that was ever a good idea, so it's not obvious this is something that needs fixing.
Since this code has been deprecated, users should have switched over to the new ImageContrastAdjustment syntax, and no one has complained about the lack of alpha-channel support. So it seems OK to have the result be different than before and/or some operations now go unsupported.