Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #1050

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fix tests #1050

merged 2 commits into from
Feb 27, 2024

Conversation

ViralBShah
Copy link
Contributor

@ViralBShah ViralBShah commented Feb 27, 2024

Fixes the Aqua tests
Add more CI platforms (adding the comprehensive set for now but will prune to a reasonable list before merging).

Fix #1049

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (ae3f7b7) to head (9880285).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1050   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files           4        4           
  Lines         226      226           
=======================================
  Hits          190      190           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnnychen94 johnnychen94 merged commit 79ee478 into master Feb 27, 2024
14 checks passed
@johnnychen94 johnnychen94 deleted the vs/tests branch February 27, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test, which is also making CI fail.
2 participants