Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml - drop very old versions in deps #1053

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

ViralBShah
Copy link
Contributor

Set ver to 0.26.1

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (79ee478) to head (b1d6b64).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files           4        4           
  Lines         226      226           
=======================================
  Hits          190      190           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor Author

@johnnychen94 I'm merging this for now, but should be easy enough to fine tune in a new PR. I'll wait for a few days to register the release.

@ViralBShah ViralBShah merged commit b03f746 into master Mar 2, 2024
9 checks passed
@ViralBShah ViralBShah deleted the vs/deps-bump branch March 2, 2024 23:14
@ViralBShah
Copy link
Contributor Author

@johnnychen94 @timholy Would it be ok to register 0.26.1 that essentially removes some of these very old deps?

@johnnychen94
Copy link
Member

Yeah! I just triggered the registration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants