Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "ImageQualityIndexes" to "0.2" #907

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ImageQualityIndexes package from 0.1.3 to 0.1.3, 0.2.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@johnnychen94
Copy link
Member

johnnychen94 commented Jul 27, 2020

CI doesn't run because the Github actions don't get triggered by another action.

It's worth noting that ImageQualityIndexes@0.2.0 introduces a breaking change to SSIM (JuliaImages/ImageQualityIndexes.jl#22), merging this PR would require a corresponding minor version bump to Images.

I'll keep it open for a few weeks, and if there's no other PRs in, I'll tag a minor release for it.

cc: @timholy

@johnnychen94 johnnychen94 added this to the v0.23 milestone Aug 3, 2020
@timholy
Copy link
Member

timholy commented Oct 8, 2020

I'd approve merging this whenever you are comfortable. I'm not going to have a lot of Julia time between now and mid-November, though, so if you're nervous about it you can also delay.

@johnnychen94
Copy link
Member

I'm good on merging this!

I was waiting for some breaking changes in colors/cvs but seems no in the near future :P

@timholy
Copy link
Member

timholy commented Oct 8, 2020

I might be able to push the CVS changes. I was planning on moving things to ColorTypes as part of that PR, but perhaps I can just hasmethod everything and make it work with any version.

@johnnychen94
Copy link
Member

Maintaining compatibility is really a pain.

#897 and #905 requires more efforts than I can put now, so I'm merging this and tag a minor release.

@johnnychen94 johnnychen94 merged commit 865912c into master Oct 8, 2020
@johnnychen94 johnnychen94 deleted the compathelper/new_version/2020-07-27-00-46-32-782-3064319970 branch October 8, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants