Fix link error on MSVC

Issue #166
JuliaInterop · Jun 22, 2024 · 57c0001 · 57c0001
1 parent e157d61
commit 57c0001
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/test-linux-mac.yml b/.github/workflows/test-linux-mac.yml
@@ -43,7 +43,7 @@ jobs:
  body: ${{ github.event.pull_request.body }}
  run: |
  package="$(echo "$body" | sed -n '1p')"
- if [ -z "${package}" ]; then
+ if [[ "$package" != "http"* ]]; then
  package="https://github.com/JuliaInterop/CxxWrap.jl.git"
  fi
  if [[ "$OSTYPE" != "darwin"* ]]; then

diff --git a/.github/workflows/test-win.yml b/.github/workflows/test-win.yml
@@ -40,10 +40,10 @@ jobs:
  cd build
  cmake -G "Visual Studio 17 2022" -A x64 -DOVERRIDES_PATH=$HOMEDRIVE/$HOMEPATH/.julia/artifacts/Overrides.toml -DOVERRIDE_ROOT=./ -DAPPEND_OVERRIDES_TOML=ON ..
  package="$(echo "$body" | sed -n '1p')"
- if [ -z "${package}" ]; then
+ if [[ "$package" != "http"* ]]; then
  package="https://github.com/JuliaInterop/CxxWrap.jl.git"
  fi
- cmake --build . --config Release
+ cmake --build . --config Debug
  julia -e "using Pkg; Pkg.Registry.add(\"General\"); Pkg.Registry.add(RegistrySpec(url = \"https://github.com/barche/CxxWrapTestRegistry.git\"))"
  julia -e "using Pkg; pkg\"add ${package}\"; using CxxWrap"
- ctest -j 1 -C Release -V
+ ctest -j 1 -C Debug -V
diff --git a/src/jlcxx.cpp b/src/jlcxx.cpp
@@ -339,6 +339,10 @@ namespace detail
  {
  }
  };
+
+ template struct JLCXX_API BasicArg<false>;
+ template struct JLCXX_API BasicArg<true>;
+
 }
 
 #ifdef JLCXX_USE_TYPE_MAP