Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard rmprocs in tests to avoid warning. Fix leaky stderr from SIGTERM test. #93

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Guard rmprocs in tests to avoid warning. Fix leaky stderr from SIGTERM test. #93

merged 2 commits into from
Feb 26, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 26, 2024 •
edited
Loading

Fixes

  | ┌ Warning: rmprocs: process 1 not removed
  | └ @ Distributed /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-XC9YQX9HH2.0/build/default-honeycrisp-XC9YQX9HH2-0/julialang/julia-master/julia-83f908a311/share/julia/stdlib/v1.12/Distributed/src/cluster.jl:1049

Fixes #15

@IanButterworth IanButterworth mentioned this pull request Feb 26, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.53%. Comparing base (8c03305) to head (41cd14f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   79.34%   71.53%   -7.81%     
==========================================
  Files          10       10              
  Lines        1951     1950       -1     
==========================================
- Hits         1548     1395     -153     
- Misses        403      555     +152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth IanButterworth changed the title guard rmprocs in tests Guard rmprocs in tests to avoid warning. Fix leaky stderr from SIGTERM test. Feb 26, 2024
@IanButterworth
Copy link
Member Author

I'd just merge this but PRs require 1 review approval

@vtjnash vtjnash merged commit 6a07d98 into master Feb 26, 2024
8 checks passed
@vtjnash vtjnash deleted the ib/guard_rmprocs branch February 26, 2024 17:01
@IanButterworth
Copy link
Member Author

Thanks. I just invoked a Distributed bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGTERM test leaks stderr interrupt trace
2 participants
@IanButterworth @vtjnash