Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for invalid string interpolation syntax #306

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

c42f
Copy link
Member

@c42f c42f commented Jun 9, 2023

Commas and semicolons are not allowed within string interpolation brackets. For example "$(x, digits=2)" is reserved syntax.

Fixes #305

Commas and semicolons are not allowed within string interpolation
brackets. For example `"$(x, digits=2)"` is reserved syntax.
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #306 (7d1f582) into main (e3e447d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   96.78%   96.80%   +0.02%     
==========================================
  Files          14       14              
  Lines        4100     4104       +4     
==========================================
+ Hits         3968     3973       +5     
+ Misses        132      131       -1     
Impacted Files Coverage Δ
src/parse_stream.jl 96.42% <ø> (ø)
src/parser.jl 98.32% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@c42f c42f merged commit af64b6d into main Jun 9, 2023
@c42f c42f deleted the c42f/string-interpolate-error branch June 9, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow tuples as atoms in interpolation syntax
1 participant