change highlight color from an RGB value to Base.error_color()
#74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGB colors have very spotty support in terminals so probably better to use something more well-supported.
Base.error_color()
is by default:light_red
but can also be customized with an env var.Ref #61
Edit: Okay I see there is this whole machinery for using RGBs so I guess this was a conscious choice. Waiting with this until there is a decision on what to do.