Skip to content

Commit

Permalink
Merge pull request #684 from JuliaLang/remove-license-dlg-msi
Browse files Browse the repository at this point in the history
Remove license dialog from MSI installer
  • Loading branch information
davidanthoff authored Jul 8, 2023
2 parents d159f27 + 3dfe3cf commit 78a32f5
Show file tree
Hide file tree
Showing 5 changed files with 83 additions and 45 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -579,8 +579,6 @@ jobs:
path: target\msi\x86_64-pc-windows-gnu\release
- name: Copy artifacts file
run: |
Copy-Item ./deploy/msi/License.rtf target\msi\x86_64-pc-windows-gnu\release
Copy-Item ./deploy/msi/License.rtf target\msi\i686-pc-windows-gnu\release
Copy-Item ./deploy/msi/Bitmaps target\msi\x86_64-pc-windows-gnu\release\ -Recurse
Copy-Item ./deploy/msi/Bitmaps target\msi\i686-pc-windows-gnu\release\ -Recurse
- name: Export version
Expand Down
5 changes: 2 additions & 3 deletions deploy/msi/Julia.wxs
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs"
xmlns:ui="http://wixtoolset.org/schemas/v4/wxs/ui">
<?include WixUI_InstallDir_NoLicense.wxs ?>
<?define ProductVersion = "1.0.0"?>
<Package Name="Julia" Manufacturer="JuliaHub, Inc." UpgradeCode="1894d99f-8e5d-44e3-acf8-9900013d4b3f" Language="1033" Codepage="1252" Version="$(var.ProductVersion)" InstallerVersion="500" ProductCode="33b218ff-20bd-47ed-b4a7-330a8c6c59b4" Scope="perUserOrMachine">
<SummaryInformation Keywords="Installer" Description="Julia Installer" Manufacturer="JuliaHub, Inc." />

<ui:WixUI Id="WixUI_InstallDir" InstallDirectory="INSTALLFOLDER" />
<ui:WixUI Id="WixUI_InstallDir_NoLicense" InstallDirectory="INSTALLFOLDER" />

<WixVariable Id="WixUIBannerBmp" Value="Bitmaps\bannrbmp.bmp" />
<WixVariable Id="WixUIDialogBmp" Value="Bitmaps\dlgbmp.bmp" />
Expand All @@ -13,8 +14,6 @@
<WixVariable Id="WixUINewIco" Value="Bitmaps\New.ico" />
<WixVariable Id="WixUIUpIco" Value="Bitmaps\Up.ico" />

<WixVariable Id="WixUILicenseRtf" Value="License.rtf" />

<Media Id="1" Cabinet="Julia.cab" EmbedCab="yes" DiskPrompt="CD-ROM #1" />
<Property Id="DiskPrompt" Value="Julia Installation [1]" />

Expand Down
38 changes: 0 additions & 38 deletions deploy/msi/License.rtf

This file was deleted.

81 changes: 81 additions & 0 deletions deploy/msi/WixUI_InstallDir_NoLicense.wxs
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. -->

<!--
First-time install dialog sequence:
- WixUI_WelcomeDlg
- WixUI_LicenseAgreementDlg
- WixUI_InstallDirDlg
- WixUI_VerifyReadyDlg
- WixUI_DiskCostDlg
Maintenance dialog sequence:
- WixUI_MaintenanceWelcomeDlg
- WixUI_MaintenanceTypeDlg
- WixUI_InstallDirDlg
- WixUI_VerifyReadyDlg
Patch dialog sequence:
- WixUI_WelcomeDlg
- WixUI_VerifyReadyDlg
-->

<Include xmlns="http://wixtoolset.org/schemas/v4/wxs">
<?foreach WIXUIARCH in X86;X64;A64 ?>
<Fragment>
<UI Id="WixUI_InstallDir_NoLicense_$(WIXUIARCH)">
<Publish Dialog="BrowseDlg" Control="OK" Event="DoAction" Value="WixUIValidatePath_$(WIXUIARCH)" Order="3" Condition="NOT WIXUI_DONTVALIDATEPATH" />
<Publish Dialog="InstallDirDlg" Control="Next" Event="DoAction" Value="WixUIValidatePath_$(WIXUIARCH)" Order="2" Condition="NOT WIXUI_DONTVALIDATEPATH" />
</UI>

<UIRef Id="WixUI_InstallDir_NoLicense" />
</Fragment>
<?endforeach?>

<Fragment>
<UI Id="file WixUI_InstallDir_NoLicense">
<TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />
<TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />
<TextStyle Id="WixUI_Font_Title" FaceName="Tahoma" Size="9" Bold="yes" />

<Property Id="DefaultUIFont" Value="WixUI_Font_Normal" />

<DialogRef Id="BrowseDlg" />
<DialogRef Id="DiskCostDlg" />
<DialogRef Id="ErrorDlg" />
<DialogRef Id="FatalError" />
<DialogRef Id="FilesInUse" />
<DialogRef Id="MsiRMFilesInUse" />
<DialogRef Id="PrepareDlg" />
<DialogRef Id="ProgressDlg" />
<DialogRef Id="ResumeDlg" />
<DialogRef Id="UserExit" />
<Publish Dialog="BrowseDlg" Control="OK" Event="SpawnDialog" Value="InvalidDirDlg" Order="4" Condition="NOT WIXUI_DONTVALIDATEPATH AND WIXUI_INSTALLDIR_VALID&lt;&gt;&quot;1&quot;" />

<Publish Dialog="ExitDialog" Control="Finish" Event="EndDialog" Value="Return" Order="999" />

<Publish Dialog="WelcomeDlg" Control="Next" Event="NewDialog" Value="InstallDirDlg" Condition="NOT Installed" />
<Publish Dialog="WelcomeDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" Condition="Installed AND PATCH" />

<Publish Dialog="InstallDirDlg" Control="Back" Event="NewDialog" Value="WelcomeDlg" />
<Publish Dialog="InstallDirDlg" Control="Next" Event="SetTargetPath" Value="[WIXUI_INSTALLDIR]" Order="1" />
<Publish Dialog="InstallDirDlg" Control="Next" Event="SpawnDialog" Value="InvalidDirDlg" Order="3" Condition="NOT WIXUI_DONTVALIDATEPATH AND WIXUI_INSTALLDIR_VALID&lt;&gt;&quot;1&quot;" />
<Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" Order="4" Condition="WIXUI_DONTVALIDATEPATH OR WIXUI_INSTALLDIR_VALID=&quot;1&quot;" />
<Publish Dialog="InstallDirDlg" Control="ChangeFolder" Property="_BrowseProperty" Value="[WIXUI_INSTALLDIR]" Order="1" />
<Publish Dialog="InstallDirDlg" Control="ChangeFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2" />
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="InstallDirDlg" Order="1" Condition="NOT Installed" />
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg" Order="2" Condition="Installed AND NOT PATCH" />
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="WelcomeDlg" Order="2" Condition="Installed AND PATCH" />

<Publish Dialog="MaintenanceWelcomeDlg" Control="Next" Event="NewDialog" Value="MaintenanceTypeDlg" />

<Publish Dialog="MaintenanceTypeDlg" Control="RepairButton" Event="NewDialog" Value="VerifyReadyDlg" />
<Publish Dialog="MaintenanceTypeDlg" Control="RemoveButton" Event="NewDialog" Value="VerifyReadyDlg" />
<Publish Dialog="MaintenanceTypeDlg" Control="Back" Event="NewDialog" Value="MaintenanceWelcomeDlg" />

<Property Id="ARPNOMODIFY" Value="1" />
</UI>

<UIRef Id="WixUI_Common" />
</Fragment>
</Include>
2 changes: 0 additions & 2 deletions scripts/msi/build_msi.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ if (Test-Path -Path $PSScriptRoot\..\..\target\x86_64-pc-windows-gnu\release) {
Write-Output "Creating x64 installer..."
md $PSScriptRoot\..\..\target\msi\x86_64-pc-windows-gnu\release -force | Out-Null
Copy-Item $PSScriptRoot\..\..\target\x86_64-pc-windows-gnu\release\*.exe $PSScriptRoot\..\..\target\msi\x86_64-pc-windows-gnu\release
Copy-Item $PSScriptRoot\..\..\deploy\msi\License.rtf $PSScriptRoot\..\..\target\msi\x86_64-pc-windows-gnu\release
Copy-Item $PSScriptRoot\..\..\deploy\msi\Bitmaps $PSScriptRoot\..\..\target\msi\x86_64-pc-windows-gnu\release -Recurse -Force
wix build -ext WixToolset.UI.wixext $PSScriptRoot\..\..\deploy\msi\Julia.wxs -b $PSScriptRoot\..\..\target\msi\x86_64-pc-windows-gnu\release -arch x64 -o $PSScriptRoot\..\..\target\msi\Julia-x64.msi
}
Expand All @@ -14,7 +13,6 @@ if (Test-Path -Path $PSScriptRoot\..\..\target\i686-pc-windows-gnu\release) {
Write-Output "Creating x86 installer..."
md $PSScriptRoot\..\..\target\msi\i686-pc-windows-gnu\release -force | Out-Null
Copy-Item $PSScriptRoot\..\..\target\i686-pc-windows-gnu\release\*.exe $PSScriptRoot\..\..\target\msi\i686-pc-windows-gnu\release
Copy-Item $PSScriptRoot\..\..\deploy\msi\License.rtf $PSScriptRoot\..\..\target\msi\i686-pc-windows-gnu\release
Copy-Item $PSScriptRoot\..\..\deploy\msi\Bitmaps $PSScriptRoot\..\..\target\msi\i686-pc-windows-gnu\release -Recurse -Force
wix build -ext WixToolset.UI.wixext $PSScriptRoot\..\..\deploy\msi\Julia.wxs -b $PSScriptRoot\..\..\target\msi\i686-pc-windows-gnu\release -arch x86 -o $PSScriptRoot\..\..\target\msi\Julia-x86.msi
}
Expand Down

0 comments on commit 78a32f5

Please sign in to comment.