Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding an override #1002

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

visr
Copy link
Sponsor Contributor

@visr visr commented Jul 25, 2024

Fixes #987.

Now we get a stderr message on override add, which indicates if an override is changed, new, or already exists.

If the channel is not installed, it gives the same error as julialauncher.

Please check carefully since I'm new to Rust. Especially not sure if the iter_mut pattern is idiomatic.

Fixes JuliaLang#987.

Now we get a stderr message on `override add`, which indicates if an override is changed, new, or already exists.

If the channel is not installed, it gives the same error as julialauncher.

Please check carefully since I'm new to Rust. Especially not sure if the `iter_mut` pattern is idiomatic.
@visr
Copy link
Sponsor Contributor Author

visr commented Aug 27, 2024

Bump :)

Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@davidanthoff davidanthoff merged commit 1f45462 into JuliaLang:main Sep 6, 2024
23 checks passed
@visr visr deleted the override-override branch October 1, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding an override
2 participants