Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user when trying to launch nonexistent linked channel #1031

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Sep 3, 2024

Only warn when adding nonexistent julia install, as I find it useful to be able to add the link before I have the julia binary.

Fixes #979

Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the check on launch we can do in some other way, but the check on link seems good as is.

src/bin/julialauncher.rs Outdated Show resolved Hide resolved
@christiangnrd christiangnrd force-pushed the warn-invalid-link branch 2 times, most recently from 0d4e516 to 01b6fd8 Compare September 6, 2024 21:59
@davidanthoff davidanthoff merged commit 9cd8fb8 into JuliaLang:main Oct 6, 2024
23 checks passed
@christiangnrd christiangnrd deleted the warn-invalid-link branch October 6, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nonexistent linked channels silently fail
2 participants