Fix DB update when julia launcher is symlinked #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a symlink
~/bin/jwhich points to thejulialauncher. Without this change,juliawas unable to findjuliaupand therefore fails intermittently, and I have to runjuliaup updateto fix this (which has been problematic if I don't have internet access).The failure mode is also odd; Julia is booted before the version update, then the launcher process exits suddenly. The REPL banner shows up, but any typing causes Julia to spit out broken pipe errors in the background of my shell.
I'd argue that some of these steps should be soft errors, eg perhaps show a warning if the DB update fails, but always launch Julia if possible. But I've not attempted that larger change.