Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Nightly channels when checking for avaliable_channels #848

Merged
merged 4 commits into from
Oct 6, 2024
Merged

Consider Nightly channels when checking for avaliable_channels #848

merged 4 commits into from
Oct 6, 2024

Commits on Oct 5, 2024

  1. Add is_valid_channel and use it everywhere `version_db.available_cha… 

    …nnels` is used
    @christiangnrd
    christiangnrd committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    cda475e View commit details
    Browse the repository at this point in the history

  2. Phrasing and comments 

    "from" makes more sense to me as the error message seems to be attempting to convey where `julialauncher` got the missing/invalid channel from.
    @christiangnrd
    christiangnrd committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    28d471e View commit details
    Browse the repository at this point in the history

  3. Address feedback

    @christiangnrd
    christiangnrd committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    5773212 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge branch 'main' into pr/christiangnrd/848

    @davidanthoff
    davidanthoff committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    7998078 View commit details
    Browse the repository at this point in the history