FreeBSD support #872

ararslan · 2024-03-19T16:01:10Z

This doesn't yet pass tests because the tarball fails to extract and I don't understand why. The URL it's using is correct and I'm able to download and unpack manually.

ararslan · 2024-03-19T16:01:50Z

Backtrace from tests (click to expand)

$ RUST_BACKTRACE=full cargo build
warning: file `/usr/home/alex/Projects/juliaup/src/bin/julialauncher.rs` found to be present in multiple build targets:
  * `bin` target `julia`
  * `bin` target `julialauncher`
   Compiling juliaup v1.14.7 (/usr/home/alex/Projects/juliaup)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 15s
$ RUST_BACKTRACE=full cargo test 
warning: file `/usr/home/alex/Projects/juliaup/src/bin/julialauncher.rs` found to be present in multiple build targets:
  * `bin` target `julia`
  * `bin` target `julialauncher`
   Compiling juliaup v1.14.7 (/usr/home/alex/Projects/juliaup)
    Finished test [unoptimized + debuginfo] target(s) in 47.42s
     Running unittests src/lib.rs (target/debug/deps/juliaup-27e8dbb220796096)

running 7 tests
test operations::tests::match_markers_none_without_markers ... ok
test operations::tests::match_markers_returns_correct_indices ... ok
test operations::tests::match_markers_returns_err_with_multiple_end ... ok
test operations::tests::match_markers_returns_err_with_multiple_start ... ok
test operations::tests::match_markers_returns_err_without_end ... ok
test operations::tests::match_markers_returns_err_without_start ... ok
test utils::tests::test_parse_versionstring ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

     Running unittests src/bin/julialauncher.rs (target/debug/deps/julia-f28678fd7035ba9e)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/bin/juliaup.rs (target/debug/deps/juliaup-60a8308d342a3057)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/channel_selection.rs (target/debug/deps/channel_selection-c6413bcb97490fba)

running 1 test
test channel_selection has been running for over 60 seconds
test channel_selection ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 71.02s

     Running tests/command_add.rs (target/debug/deps/command_add-1879bb0894255f75)

running 1 test
test command_add ... FAILED

failures:

---- command_add stdout ----
thread 'command_add' panicked at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5:
Unexpected failure.
code=1
stderr=``````
Installing Julia latest-freebsd-x86_64
Error: Failed to download and extract nightly: Failed to extract downloaded file from url `https://julialangnightlies-s3.julialang.org/bin/freebsd/x86_64/julia-latest-freebsd-x86_64.tar.gz`.

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /home/alex/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.79/src/error.rs:83:36
   1: juliaup::operations::install_from_url
             at ./src/operations.rs:463:13
   2: juliaup::operations::install_nightly
             at ./src/operations.rs:534:15
   3: juliaup::command_add::add_nightly
             at ./src/command_add.rs:84:26
   4: juliaup::command_add::run_command_add
             at ./src/command_add.rs:11:16
   5: juliaup::main
             at ./src/bin/juliaup.rs:59:37
   6: core::ops::function::FnOnce::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
   7: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:155:18
   8: std::rt::lang_start::{{closure}}
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:166:18
   9: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:284:13
  10: std::panicking::try::do_call
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:552:40
  11: std::panicking::try
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:516:19
  12: std::panic::catch_unwind
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panic.rs:142:14
  13: std::rt::lang_start_internal::{{closure}}
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:148:48
  14: std::panicking::try::do_call
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:552:40
  15: std::panicking::try
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:516:19
  16: std::panic::catch_unwind
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panic.rs:142:14
  17: std::rt::lang_start_internal
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:148:20
  18: std::rt::lang_start
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:165:17
  19: main
  20: __libc_start1
             at /usr/src/lib/libc/csu/libc_start1.c:157:7
  21: _start
             at /usr/src/lib/csu/amd64/crt1_s.S:83
```
```
command=`JULIAUP_DEPOT_PATH="/tmp/.tmpt52UIs" JULIA_DEPOT_PATH="/tmp/.tmpt52UIs" "/usr/home/alex/Projects/juliaup/target/debug/juliaup" "add" "nightly"`
code=1
stdout=""
stderr=```
Installing Julia latest-freebsd-x86_64
Error: Failed to download and extract nightly: Failed to extract downloaded file from url `https://julialangnightlies-s3.julialang.org/bin/freebsd/x86_64/julia-latest-freebsd-x86_64.tar.gz`.

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /home/alex/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.79/src/error.rs:83:36
   1: juliaup::operations::install_from_url
             at ./src/operations.rs:463:13
   2: juliaup::operations::install_nightly
             at ./src/operations.rs:534:15
   3: juliaup::command_add::add_nightly
             at ./src/command_add.rs:84:26
   4: juliaup::command_add::run_command_add
             at ./src/command_add.rs:11:16
   5: juliaup::main
             at ./src/bin/juliaup.rs:59:37
   6: core::ops::function::FnOnce::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
   7: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:155:18
   8: std::rt::lang_start::{{closure}}
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:166:18
   9: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:284:13
  10: std::panicking::try::do_call
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:552:40
  11: std::panicking::try
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:516:19
  12: std::panic::catch_unwind
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panic.rs:142:14
  13: std::rt::lang_start_internal::{{closure}}
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:148:48
  14: std::panicking::try::do_call
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:552:40
  15: std::panicking::try
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:516:19
  16: std::panic::catch_unwind
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panic.rs:142:14
  17: std::rt::lang_start_internal
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:148:20
  18: std::rt::lang_start
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/rt.rs:165:17
  19: main
  20: __libc_start1
             at /usr/src/lib/libc/csu/libc_start1.c:157:7
  21: _start
             at /usr/src/lib/csu/amd64/crt1_s.S:83
```


stack backtrace:
   0:     0x32c2adb78076 - std::backtrace_rs::backtrace::libunwind::trace::h7240633c0010cc0c
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x32c2adb78076 - std::backtrace_rs::backtrace::trace_unsynchronized::ha2c7a5c96fbc8505
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x32c2adb78076 - std::sys_common::backtrace::_print_fmt::hd469fe19c1c8394f
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:68:5
   3:     0x32c2adb78076 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h579f177009daf63c
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:44:22
   4:     0x32c2adba2d30 - core::fmt::rt::Argument::fmt::hd069ebef5ef6ecf2
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/fmt/rt.rs:142:9
   5:     0x32c2adba2d30 - core::fmt::write::hdac3a427c10c4f97
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/fmt/mod.rs:1120:17
   6:     0x32c2adb74baf - std::io::Write::write_fmt::hede81785d7f048d1
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/io/mod.rs:1810:15
   7:     0x32c2adb77e54 - std::sys_common::backtrace::_print::hfa6dbd0c85e91f76
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:47:5
   8:     0x32c2adb77e54 - std::sys_common::backtrace::print::h108ec5c827b50278
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:34:9
   9:     0x32c2adb79917 - std::panicking::default_hook::{{closure}}::h963a7edfbc073915
  10:     0x32c2adb7961d - std::panicking::default_hook::h8e8085b99e7345eb
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:289:9
  11:     0x32c2ad82cb07 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h0bec7cb0f6b7b94a
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2029:9
  12:     0x32c2ad82cb07 - test::test_main::{{closure}}::he7ced423a7faeae3
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/test/src/lib.rs:138:21
  13:     0x32c2adb7a00d - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::hf66dc46e35826ba0
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2029:9
  14:     0x32c2adb7a00d - std::panicking::rust_panic_with_hook::hd05c0541950740f4
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:783:13
  15:     0x32c2adb79d52 - std::panicking::begin_panic_handler::{{closure}}::h8bfba3147bcb3614
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:657:13
  16:     0x32c2adb78576 - std::sys_common::backtrace::__rust_end_short_backtrace::h163b8cf687c9f743
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:171:18
  17:     0x32c2adb79ab0 - rust_begin_unwind
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:645:5
  18:     0x32c2adba0d15 - core::panicking::panic_fmt::h8d1bb268d5ef243e
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:72:14
  19:     0x32c2ad838f9f - core::panicking::panic_display::h001ba5e4ba9bf4b2
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:196:5
  20:     0x32c2ad83c91e - assert_cmd::assert::AssertError::panic::panic_cold_display::h6b37e029948dc0d5
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panic.rs:99:13
  21:     0x32c2ad83ac27 - assert_cmd::assert::AssertError::panic::ha16d1fcdedc6a331
                               at /home/alex/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_cmd-2.0.13/src/assert.rs:1033:9
  22:     0x32c2ad843077 - core::ops::function::FnOnce::call_once::h356ba518d73ccf99
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
  23:     0x32c2ad84552f - core::result::Result<T,E>::unwrap_or_else::h659dcae9e2d4db1c
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/result.rs:1426:23
  24:     0x32c2ad83a166 - assert_cmd::assert::Assert::success::h0f4aa7bd61694c1a
                               at /home/alex/.cargo/registry/src/index.crates.io-6f17d22bba15001f/assert_cmd-2.0.13/src/assert.rs:158:9
  25:     0x32c2ad7e9e82 - command_add::command_add::hc9a85be4a188313e
                               at /usr/home/alex/Projects/juliaup/tests/command_add.rs:18:5
  26:     0x32c2ad7e8547 - command_add::command_add::{{closure}}::h0474660538de43c5
                               at /usr/home/alex/Projects/juliaup/tests/command_add.rs:5:17
  27:     0x32c2ad7ea616 - core::ops::function::FnOnce::call_once::h679daccd76ce5bcf
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
  28:     0x32c2ad83238f - core::ops::function::FnOnce::call_once::h73428c76b37975a0
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
  29:     0x32c2ad83238f - test::__rust_begin_short_backtrace::he8ead63f1b14979b
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/test/src/lib.rs:627:18
  30:     0x32c2ad83116e - test::run_test_in_process::{{closure}}::hb19e40931d728242
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/test/src/lib.rs:650:60
  31:     0x32c2ad83116e - <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h137e3c5834ce42f2
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panic/unwind_safe.rs:272:9
  32:     0x32c2ad83116e - std::panicking::try::do_call::h981ec909ebe66d3d
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:552:40
  33:     0x32c2ad83116e - std::panicking::try::h6a8ac355d2c05b51
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:516:19
  34:     0x32c2ad83116e - std::panic::catch_unwind::he5484ce6066eec19
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panic.rs:142:14
  35:     0x32c2ad83116e - test::run_test_in_process::he21ef0196cf852c5
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/test/src/lib.rs:650:27
  36:     0x32c2ad83116e - test::run_test::{{closure}}::h96161358f8f07f3d
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/test/src/lib.rs:573:43
  37:     0x32c2ad7f5e16 - test::run_test::{{closure}}::ha89a98e7aac5a3ca
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/test/src/lib.rs:601:41
  38:     0x32c2ad7f5e16 - std::sys_common::backtrace::__rust_begin_short_backtrace::hf41028e6b16049a3
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys_common/backtrace.rs:155:18
  39:     0x32c2ad7fb037 - std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}::h7a86dfcd69fe5a2b
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/thread/mod.rs:529:17
  40:     0x32c2ad7fb037 - <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h7ef355326916622a
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panic/unwind_safe.rs:272:9
  41:     0x32c2ad7fb037 - std::panicking::try::do_call::ha2cf9d94c9f940ca
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:552:40
  42:     0x32c2ad7fb037 - std::panicking::try::hb19633da3c7b0a83
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:516:19
  43:     0x32c2ad7fb037 - std::panic::catch_unwind::h33d6f55f15e036bb
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panic.rs:142:14
  44:     0x32c2ad7fb037 - std::thread::Builder::spawn_unchecked_::{{closure}}::h61726f914b2c59c7
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/thread/mod.rs:528:30
  45:     0x32c2ad7fb037 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h79a05a5a909288a3
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
  46:     0x32c2adb7fe85 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h416b9e2948292dac
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2015:9
  47:     0x32c2adb7fe85 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::ha651b059e126a744
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/alloc/src/boxed.rs:2015:9
  48:     0x32c2adb7fe85 - std::sys::unix::thread::Thread::new::thread_start::h83716b035e61a5a7
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/sys/unix/thread.rs:108:17
  49:     0x32cacfcb0a75 - thread_start
                               at /usr/src/lib/libthr/thread/thr_create.c:290:16


failures:
    command_add

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 29.38s

error: test failed, to rerun pass `--test command_add`

ararslan · 2024-03-20T09:51:53Z

Actually the unpacking thing might be a red herring possibly caused by with_context attaching the wrong context to a different error. I removed the ? in

juliaup/src/operations.rs

Line 48 in 20a20b9

entry.unpack(dst.as_ref().join(path))?;

and now the error is that libjulia-codegen.so.1.12 can't load libLLVM-16jl.so. Last I checked (a day or two ago) I didn't see that locally when manually downloading, unpacking, and using nightly. So still doesn't work but... progress?

scripts/versiondb/updateversiondb.jl

ararslan · 2024-06-05T00:44:08Z

Swapping the tar crate for binstall-tar, a fork that fixes alexcrichton/tar-rs#295, fixed the primary failure. The test that fails now is related to pulling versiondb from S3, and there isn't one for FreeBSD there. Perhaps I'll separate out the versiondb changes from this PR so that those can be merged first.

ararslan · 2024-06-05T00:50:54Z

...except it didn't fail on CI, huh. The test I mentioned fails locally.

.github/workflows/test.yml

ararslan · 2024-06-06T03:23:17Z

Some to-do items:

As @davidanthoff and I discussed in Slack, using the binstall-tar crate in place of tar is not ideal since the former seems unmaintained; it reflects tar v0.4.39 with the first commit from Add support for PAX Format, Version 1.0 alexcrichton/tar-rs#298 applied, but does not include any of the changes made to upstream tar since then. Some options we discussed, which are not necessarily mutually exclusive:
- Make binstall-tar a conditional dependency such that it's used for FreeBSD while tar is used for other platforms.
- If the author of the linked tar PR doesn't respond, make a new PR based on it with conflicts resolved in order to move forward.
- Temporarily maintain our own fork of tar, despite neither David nor I knowing enough about that crate nor the fixes in the linked PR to warrant doing so...
- Use binstall-tar on all platforms (currently implemented in this PR). This means we don't benefit from any updates or fixes in upstream tar.
Add FreeBSD to the release building setup.

ararslan · 2024-06-07T16:27:20Z

binstall-tar has now been synced with upstream tar (cargo-bins/tar-rs#1) and a v0.4.42 release has been published. IMO it seems reasonable to switch to binstall-tar (currently implemented in this PR) until tar has been updated to include the necessary fixes.

ararslan · 2024-09-21T23:15:48Z

Everything is working now, though I ended up taking a slightly different approach from when I started this. It looks like it might be a long time before the tar-rs PR that would allow us to properly read tarballs produced by BSD tar is merged, if it ever is. In the meantime, we can simply spawn a tar process to do the unpacking. This seems to work just fine.

I think this is finally ready for review, @davidanthoff. It's worth noting up front that I don't actually know Rust so there may be better ways to implement this approach.

davidanthoff

Looks great! The only thing I found is that ideally we would use conditional compiles in two places, could you try whether that works?

src/operations.rs

davidanthoff · 2024-10-04T22:31:23Z

Oh, one more question: so this uses the download script and then the self-update option. I'm wondering whether there is also a system package manager on FreeBSD that we could utilize to distribute things? I think in general my hope is that over time we can utilize system package managers as much as possible to get Juliaup onto user's machines, and only use the download script on platforms where there isn't really a compelling story (ahem, Mac...).

ararslan · 2024-10-04T23:54:04Z

There is, the system package manager is called pkg. They don't typically redistribute third party binaries though, preferring to compile things themselves as part of the "ports" system. (Think macOS Homebrew if there was no --cask option.) It also doesn't seem to be very easy to contribute to, nor to monitor for issues. IMO it's worth using download + self-update in the near term and look into adding a port in the future.

Note that this uses command line tar instead of tar-rs on FreeBSD. Unlike most systems, we can be quite sure that `tar` exists when running on FreeBSD, so it should be safe to call out to it and fail with a descriptive error in the off chance that the host system is weird. This allows us to avoid using the Rust tar library, which does not currently support the POSIX-2008.1 format that is produced by default by BSD tar.

ararslan · 2024-10-05T20:40:58Z

Cleaned up my commit mess and rebased on main to make extra sure things continue to work as expected here with the updated dependencies.

davidanthoff

Very nice, thanks for pushing it over the finishing line!

davidanthoff · 2024-10-05T22:20:42Z

IMO it's worth using download + self-update in the near term and look into adding a port in the future.

Yes, that sounds like a good plan.

They don't typically redistribute third party binaries though, preferring to compile things themselves as part of the "ports" system.

So that might work for us, because we can easily have them compile julialauncher and juliaup etc, right?

giordano reviewed May 29, 2024

View reviewed changes

scripts/versiondb/updateversiondb.jl Outdated Show resolved Hide resolved

ararslan mentioned this pull request Jun 5, 2024

Include FreeBSD when generating versiondb #948

Merged

ararslan force-pushed the aa/freebsd branch from 2f07e55 to 0eafc01 Compare June 5, 2024 23:28

ararslan commented Jun 5, 2024

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

ararslan force-pushed the aa/freebsd branch from 77b2e10 to 8714587 Compare June 6, 2024 22:36

davidanthoff mentioned this pull request Jun 19, 2024

Feature Request: FreeBSD support #963

Closed

ararslan force-pushed the aa/freebsd branch from 7677e0b to 76dfa62 Compare September 21, 2024 22:47

ararslan marked this pull request as ready for review September 21, 2024 23:09

ararslan requested a review from davidanthoff September 21, 2024 23:09

davidanthoff reviewed Oct 4, 2024

View reviewed changes

src/operations.rs Outdated Show resolved Hide resolved

src/operations.rs Outdated Show resolved Hide resolved

ararslan requested a review from davidanthoff October 5, 2024 00:52

ararslan force-pushed the aa/freebsd branch from c309c9e to 8d41dfd Compare October 5, 2024 20:39

davidanthoff approved these changes Oct 5, 2024

View reviewed changes

davidanthoff merged commit 88ef7de into main Oct 5, 2024
25 checks passed

davidanthoff deleted the aa/freebsd branch October 5, 2024 22:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FreeBSD support #872

FreeBSD support #872

ararslan commented Mar 19, 2024

ararslan commented Mar 19, 2024

ararslan commented Mar 20, 2024

ararslan commented Jun 5, 2024

ararslan commented Jun 5, 2024

ararslan commented Jun 6, 2024

ararslan commented Jun 7, 2024

ararslan commented Sep 21, 2024

davidanthoff left a comment

davidanthoff commented Oct 4, 2024

ararslan commented Oct 4, 2024

ararslan commented Oct 5, 2024

davidanthoff left a comment

davidanthoff commented Oct 5, 2024

FreeBSD support #872

FreeBSD support #872

Conversation

ararslan commented Mar 19, 2024

ararslan commented Mar 19, 2024

ararslan commented Mar 20, 2024

ararslan commented Jun 5, 2024

ararslan commented Jun 5, 2024

ararslan commented Jun 6, 2024

ararslan commented Jun 7, 2024

ararslan commented Sep 21, 2024

davidanthoff left a comment

Choose a reason for hiding this comment

davidanthoff commented Oct 4, 2024

ararslan commented Oct 4, 2024

ararslan commented Oct 5, 2024

davidanthoff left a comment

Choose a reason for hiding this comment

davidanthoff commented Oct 5, 2024