Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to trigger CI #114

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Update README.md to trigger CI #114

merged 1 commit into from
Oct 14, 2022

Conversation

ViralBShah
Copy link
Contributor

@ViralBShah ViralBShah commented Oct 12, 2022

@amontoison - Running CI here to see if we can tag MKL 0.6. We can tag MKL 0.6 if this basically works on all the platforms. There are some tests failing because of numerical precision mismatch in MKL 2021/2022, e.g. gsvd - but that shouldn't hold up the version bump.

This should help jump-dev/Ipopt.jl#327

@ViralBShah
Copy link
Contributor Author

ViralBShah commented Oct 12, 2022

I think this looks pretty good. I feel we can go ahead and tag 0.6. Win64 tests did pass locally for me.

Anyone know what this is:

      From worker 27:	┌ Error: The `LinearAlgebra/addmul` test set mutated ENV and did not restore the original values

@KristofferC @DilumAluthge @chriselrod

@amontoison
Copy link
Contributor

amontoison commented Oct 12, 2022

Thanks @ViralBShah! I also use LBT for HSL.jl and It's great to easily switch between OpenBLAS32 and LP64 MKL with just using MKL.

@DilumAluthge
Copy link
Member

I think this looks pretty good. I feel we can go ahead and tag 0.6. Win64 tests did pass locally for me.

Anyone know what this is:

      From worker 27:	┌ Error: The `LinearAlgebra/addmul` test set mutated ENV and did not restore the original values

@KristofferC @DilumAluthge @chriselrod

This is a test to make sure that if a test sets mutates ENV, it restores the original values at the end of the test set. This is to ensure that modifications to ENV do not persist between test sets.

Does MKL.jl mutate ENV?

@DilumAluthge
Copy link
Member

That check is important in Base CI, where we want to keep earlier test sets from causing problems for later test sets.

It's less useful here. We can add an escape hatch so that you can disable that check in this repo while keeping the check for Base CI.

@DilumAluthge
Copy link
Member

We can add an escape hatch so that you can disable that check in this repo while keeping the check for Base CI.

JuliaLang/julia#47148

@ViralBShah ViralBShah merged commit 06026a8 into master Oct 14, 2022
@ViralBShah ViralBShah deleted the vs/triggerci branch October 14, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants