Skip to content

Commit

Permalink
Mark broken test as passing
Browse files Browse the repository at this point in the history
The issue we were having before on GitHub-hosted Actions runners appears to have
been fixed.
  • Loading branch information
giordano committed Sep 25, 2024
1 parent b77c32e commit 90c98b5
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions test/runners.jl
Original file line number Diff line number Diff line change
Expand Up @@ -545,10 +545,7 @@ end
set -e
make -j${nproc} -sC /usr/share/testsuite install
"""
# This test fails on GitHub Actions with non-squashfs on UserNS runners:
# <https://github.com/JuliaPackaging/BinaryBuilderBase.jl/issues/347>.
is_broken = get(ENV, "GITHUB_ACTIONS", "false")=="true" && !(BinaryBuilderBase.use_squashfs[]) && BinaryBuilderBase.preferred_runner() == BinaryBuilderBase.UserNSRunner
@test run(ur, `/bin/bash -c "$(test_script)"`, iobuff) broken=is_broken
@test run(ur, `/bin/bash -c "$(test_script)"`, iobuff)
end
end
end

0 comments on commit 90c98b5

Please sign in to comment.