Skip to content

Commit

Permalink
[Sources] Explicit conversion to work around breaking change in Progr…
Browse files Browse the repository at this point in the history
…essMeter (#373)

* [Sources] Explicit conversion to work around breaking change in ProgressMeter

This was broken by <timholy/ProgressMeter.jl#304>.

* [CI] Do not run tests on nightly

They're irremediably broken, no one is going to fix it, no point it keeping
running tests bound to fail.
  • Loading branch information
giordano authored Apr 3, 2024
1 parent 0b0372d commit daa758c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ jobs:
squashfs: true
julia-version: "1.10"

- runner: privileged
squashfs: true
julia-version: "nightly"
# - runner: privileged
# squashfs: true
# julia-version: "nightly"

# Add a job that uses the unprivileged builder with unpacked shards
- runner: unprivileged
Expand Down
4 changes: 2 additions & 2 deletions src/Sources.jl
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,10 @@ end
function transfer_progress(progress::Ptr{GitTransferProgress}, payloads::Dict)
p = payloads[:transfer_progress]
progress = unsafe_load(progress)
p.n = progress.total_objects

This comment has been minimized.

Copy link
@MarcMush

MarcMush Apr 3, 2024

the better way of doing this is update!(p; max_steps=progress.total_objects) which should never break (hopefully)
I have to admit it's not documented (yet?)

p.n = Int(progress.total_objects)
if progress.total_deltas != 0
p.desc = "Resolving Deltas: "
p.n = progress.total_deltas
p.n = Int(progress.total_deltas)
update!(p, Int(max(1, progress.indexed_deltas)))
else
update!(p, Int(max(1, progress.received_objects)))
Expand Down

0 comments on commit daa758c

Please sign in to comment.