Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaPILO requires OpenBLAS #5437

Merged
merged 4 commits into from
Sep 17, 2022
Merged

Conversation

matbesancon
Copy link
Contributor

Resolving
JuliaRegistries/General#67137 (comment)
I'm surprised this didn't break earlier

@amontoison
Copy link
Contributor

amontoison commented Sep 7, 2022

@matbesancon
The issue is probably with Ipopt_jll. We recompile Ipopt and MUMPS_jll with LBT_jll and you need to provide a 32 bits BLAS backend directly in your package.
jump-dev/Ipopt.jl#327

@matbesancon
Copy link
Contributor Author

in that case, there seems to be a Blas dependency in PaPILO itself, hence my surprise that things didn't break before

@matbesancon
Copy link
Contributor Author

can we merge this? cc @giordano

@giordano
Copy link
Member

giordano commented Sep 9, 2022

I'm not sure this is the right fix. How did libscip end up linking to libopenblas, if that wasn't in the same environment in the first place?

@matbesancon
Copy link
Contributor Author

How did libscip end up linking to libopenblas

through papilo, I have to check exactly where it is needed

@matbesancon
Copy link
Contributor Author

@giordano it seems papilo does require it:
https://github.com/scipopt/papilo/blob/master/CMakeLists.txt#L177

@giordano
Copy link
Member

What is not clear to me is: how this ended up linking to openblas if openblas wasn't a (direct at least) dependency? What has changed since last build? Without clear answers to these questions I can't tell what's going on here.

@imciner2
Copy link
Member

What is not clear to me is: how this ended up linking to openblas if openblas wasn't a (direct at least) dependency? What has changed since last build? Without clear answers to these questions I can't tell what's going on here.

CMake includes the detection logic for BLAS libraries in its default install, so as long as the library and include headers exist in the library/include folder, CMake will happily find it even if we don't have a listed direct dependency on it. Ipopt (or another package) probably previously relied on OpenBLAS when this was last built, so it was transitively added into the right directories in the build image, and therefore the CMake logic automatically picked it up and linked it without throwing an error at configure/link time. Now that the transitive dependency is broken, it broke at runtime.

@giordano
Copy link
Member

Ok, now I see. Thanks for the recap!

@giordano giordano merged commit e610d2e into JuliaPackaging:master Sep 17, 2022
@giordano
Copy link
Member

For the record: #5525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants