Skip to content

Commit

Permalink
Add precompile step for rePCA (#749)
Browse files Browse the repository at this point in the history 
* add precompile workfload for PCA

* ignore version specific manifests

* patch bump, NEWS
  • Loading branch information
@palday
palday authored Sep 3, 2024
1 parent 0ad0594 commit 2ed1933
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@ docs/src/assets/*.svg
test/scratch.jl
tune.json
Manifest.toml
Manifest-v1.*.toml
Manifest-v*.toml
settings.json
docs/jmd
LocalPreferences.toml
benchmark.md

lcov.info
coverage/
5 changes: 5 additions & 0 deletions NEWS.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
MixedModels v4.25.4 Release Notes
==============================
- Added additional precompilation for rePCA. [#749]

MixedModels v4.25.3 Release Notes
==============================
- Fix a bug in the handling of rank deficiency in the `simulate[!]` code. This has important correctness implications for bootstrapping models with rank-deficient fixed effects (as can happen in the case of partial crossing of the fixed effects / missing cells). [#778]
Expand Down Expand Up @@ -545,6 +549,7 @@ Package dependencies
[#740]: https://github.com/JuliaStats/MixedModels.jl/issues/740
[#744]: https://github.com/JuliaStats/MixedModels.jl/issues/744
[#748]: https://github.com/JuliaStats/MixedModels.jl/issues/748
[#749]: https://github.com/JuliaStats/MixedModels.jl/issues/749
[#755]: https://github.com/JuliaStats/MixedModels.jl/issues/755
[#756]: https://github.com/JuliaStats/MixedModels.jl/issues/756
[#767]: https://github.com/JuliaStats/MixedModels.jl/issues/767
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MixedModels"
uuid = "ff71e718-51f3-5ec2-a782-8ffcbfa3c316"
author = ["Phillip Alday <me@phillipalday.com>", "Douglas Bates <dmbates@gmail.com>", "Jose Bayoan Santiago Calderon <jbs3hp@virginia.edu>"]
version = "4.25.3"
version = "4.25.4"

[deps]
Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"
Expand Down
6 changes: 5 additions & 1 deletion src/MixedModels.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -213,15 +213,19 @@ include("profile/profile.jl")
sleepstudy = dataset(:sleepstudy)
contra = dataset(:contra)
progress = false
io = IOBuffer()
@compile_workload begin
# all calls in this block will be precompiled, regardless of whether
# they belong to your package or not (on Julia 1.8 and higher)

# these are relatively small models and so shouldn't increase precompile times all that much
# while still massively boosting load and TTFX times
fit(MixedModel,
m = fit(MixedModel,
@formula(reaction ~ 1 + days + (1 + days | subj)),
sleepstudy; progress)
show(io, m)
show(io, m.PCA.subj)
show(io, m.rePCA)
fit(MixedModel,
@formula(use ~ 1 + age + abs2(age) + urban + livch + (1 | urban & dist)),
contra,
Expand Down

2 comments on commit 2ed1933

@palday
Copy link
Member Author

@palday palday commented on 2ed1933 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/114448

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v4.25.4 -m "<description of version>" 2ed1933bfa7bed59607eaaf9ff6e6453250250a7
git push origin v4.25.4

Please sign in to comment.