Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error string for GATT_INVALID_ATTRIBUTE_LENGTH #831

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

angusholder
Copy link
Contributor

Looks like a typo or copy-paste mistake? "Invalid attribute" is a bit different to "Invalid attribute length" - made it sound like the attribute didn't exist, when actually I was just not sending a big enough payload for the write!

@angusholder angusholder requested review from twyatt and a team as code owners January 15, 2025 15:34
Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yikes. Definitely a mistake. Thanks for catching/fixing this!

@twyatt twyatt added the patch Changes that should bump the PATCH version number label Jan 15, 2025
@twyatt twyatt enabled auto-merge (squash) January 17, 2025 22:44
@twyatt twyatt disabled auto-merge January 17, 2025 22:44
@twyatt twyatt enabled auto-merge (squash) January 17, 2025 22:44
@twyatt twyatt changed the title Fix error string for GATT_INVALID_ATTRIBUTE_LENGTH Fix error string for GATT_INVALID_ATTRIBUTE_LENGTH Jan 17, 2025
@twyatt twyatt merged commit 7257014 into JuulLabs:main Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants