Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend i18n #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

extend i18n #78

wants to merge 2 commits into from

Conversation

X-20A
Copy link

@X-20A X-20A commented Jun 30, 2024

#77

@fourinone41
Copy link
Contributor

fourinone41 commented Jun 30, 2024

Thank you, much appreciated!
By the way, don't worry about implementing i18n switching logic, I had already started on my end, and changed some structure, but I didn't push to public yet. If it's easier for you, you can just hardcode in JP, or only write a list of translated terms for now. Also don't worry about cases such as <img> or <input> inside sentences, please re-order those however you think is best for JP, and I can handle on my end.

@fourinone41
Copy link
Contributor

fourinone41 commented Jul 1, 2024

I've pushed new branch i18n (WIP, still missing some strings from js). i18n terms are now in js/data/strings_en.json, js/data/strings_ja.json, with your already translated terms copied over.

Please review, since format now allows <input> etc in any order:

  • retreat_on_taiha
  • retreat_on_taiha_even
  • replace_formations
  • bucket_count_use
  • bucket_do_not_count_use
  • carry_over_ship_hp
  • DD_n
  • other_n
  • simulate_n_times_and_show_stats
  • avg_n_hp_per_run
  • avg_n_hp_per_boss
  • avg_n_tp_per_run
  • mvp_rate_per_battle
  • ship_n
  • taiha_rate_per_battle
  • no_chuuha_after_battle
  • avg_resource_per
  • autoscale_stats

Question: Do you need : included as part of i18n terms? e.g. {{$t('set_all_morale_to')}} -> "Cond値一括適用:" vs {{$t('set_all_morale_to')}}: -> "Cond値一括適用":

(from #76 )

S rate: 63.5% (retreat: 12.8%, non-S: 23.7%)

Is this OK? If so, do you have JP for non-S and Flagship not sunk?

@X-20A
Copy link
Author

X-20A commented Jul 1, 2024

Thanks for setting this up.
I'll keep working on it.

S rate: 63.5% (retreat: 12.8%, non-S: 23.7%)
I still feel the 'other' part is redundant, but it's not bad.
In Japanese,
non-S: S以外
Flagship not sunk: 旗艦撃沈以外
but both of them can be put together as
その他
I think it would be cleaner to put them both together as

@X-20A
Copy link
Author

X-20A commented Jul 1, 2024

In "Mechanic: AACI Rework (sequential roll and new AACI priority), Additional Stats show fleetwide AACI rate", does 'sequential roll' mean multiplexing?

In 'Air Support Sub node settings, update Night Zuiun Cut-In trigger rate (removed Advanced Setting) + show in Additional Stats' does 'Air Support Sub node settings' refers to the support fleet?

What is Phase 2 of "Carry over HP/Morale option, update presets to Phase 2 comps, vanguard formation"?

Historical Bonus config, Nelson/Nagato/Mutsu specials (day only currently), new mechanics: new installation mods/new resource costs/new echelon What is 'new resource costs' in 'mods'?

What is 'vs LBAS' in #divAdditionalStats?

What does "Effective" in "Effective LoS" mean?

The following are things that occurred to me while translating and have nothing to do with the translation

Why is "Use default World 6 costs for Air Raid" not ON by default?

Do you not use the estimated formula for the activation rate of the special bombardment?
If not, shouldn't it be added in the NOTE? (because it has a large impact)
https://en.kancollewiki.net/Special_Attacks#Trigger_Rate

Wouldn't it be better to make it clear what exactly is included in "Avg Resupply"?
For example, "fleet + support fleet + LBAS" in the same way as "closet alternative".

Maybe we should make it clear that 'Standard Accuracy' and 'Standard Evasion' take into account increases due to luck and level.

'Override Support Fleet Chance' should be made clear that it is set with the antenna in mind.

@fourinone41
Copy link
Contributor

fourinone41 commented Jul 1, 2024

Ah, I think changelogs can be low priority for now since they may not be so relevant anymore, but no problem if you're interested in translating them anyway.

In "Mechanic: AACI Rework (sequential roll and new AACI priority), Additional Stats show fleetwide AACI rate", does 'sequential roll' mean multiplexing?

"Sequential roll" refers to the AACI mechanics update on 2023-05-26, where now individual AACI types are rolled "one after another". https://en.kancollewiki.net/Sequential_AACI

In 'Air Support Sub node settings, update Night Zuiun Cut-In trigger rate (removed Advanced Setting) + show in Additional Stats' does 'Air Support Sub node settings' refers to the support fleet?

This setting:
image

What is Phase 2 of "Carry over HP/Morale option, update presets to Phase 2 comps, vanguard formation"?

"Phase 2" refers to the major update in 2018 when all normal maps were reworked. So here I replaced old maps' enemy comps with new maps' enemy comps.

Historical Bonus config, Nelson/Nagato/Mutsu specials (day only currently), new mechanics: new installation mods/new resource costs/new echelon What is 'new resource costs' in 'mods'?

I meant these 3 settings under Mechanics:
image
"New Fuel/Ammo Node Costs" toggles between old and new node costs (e.g. 20% -> 8% fuel for submarine nodes) which were changed during Phase 2 update.

What is 'vs LBAS' in #divAdditionalStats?

The air power value which enemy fleets use against player's LBAS (which is different because recons etc are counted)

What does "Effective" in "Effective LoS" mean?

The LoS used for map branching. This formula: https://wikiwiki.jp/kancolle/%E3%83%AB%E3%83%BC%E3%83%88%E5%88%86%E5%B2%90#los_formula

Why is "Use default World 6 costs for Air Raid" not ON by default?

OFF = use 6%/4% for raid node cost (used by all event, world 5, world 7, etc)
ON = use 4%/8% for raid node cost (used by world 6 only)
So it's only for when you want to simulate world 6 maps.

Do you not use the estimated formula for the activation rate of the special bombardment?
If not, shouldn't it be added in the NOTE? (because it has a large impact)

Currently it does not, as I was told that those formulas may be inaccurate, and we have not been able to confirm personally with DB. Good idea, I am thinking about adding a note/warning similar to DD vanguard and smoke.

Wouldn't it be better to make it clear what exactly is included in "Avg Resupply"?
For example, "fleet + support fleet + LBAS" in the same way as "closet alternative".

Good idea, I will add a tooltip.

Maybe we should make it clear that 'Standard Accuracy' and 'Standard Evasion' take into account increases due to luck and level.

Maybe can also add tooltip for this?

'Override Support Fleet Chance' should be made clear that it is set with the antenna in mind.

Sure, I can add a note.

@X-20A
Copy link
Author

X-20A commented Jul 2, 2024

Sorry.
I still don't understand "vs LBAS".
I found a description on the Japanese wiki, but my understanding is that it means "the base air force's air superiority value also includes the air superiority value of reconnaissance aircraft", for example, in this data the Spitfire's air superiority value: 76 is added to the reconnaissance aircraft's air superiority value: 7. I just don't understand why it is combined with the main squadron's air superiority value in "vs LBAS".

@X-20A
Copy link
Author

X-20A commented Jul 2, 2024

Questions about translation are addressed here in the comments. It is the same as the original file except for the comments.

@X-20A
Copy link
Author

X-20A commented Jul 2, 2024

The following is not related to translation

  • 'Ship has customised stats' icon is confusing when the background is white.
    I think it would be better to use a color that can be easily distinguished from the background, and to shift the position of the "! which stands for unknown, should be shifted as well.
  • When loading the composition, shouldn't it be loaded at the time the fleet type is selected?
  • I think it would be better for users to know if the bonuses set in fleetSection are cumulative with bonuses set elsewhere, or if they are overwritten.
  • Can't 'Mechanics' and 'soft caps' be folded?
  • I think it would be more practical to list the Worlds in the KCNavImporter list of Worlds in order of newest after World 6.
    It might be possible to put the event sea area under deployment on top of World 1.
  • It would be nice to have a toolTip on the rules for specifying the KCNavImporter Phase.
  • If you are targeting general users for bug reports and requests, I think it is a high threshold to ask them to set up an Issue on Github. It might be better to implement a message function or use a service like the Subject Box and decide separately whether to set up an Issue.
  • The "Show Advanced" is a very nice feature (I don't think there is any other way to see all the special attacks and CIs for the entire fleet at once) and it would be worth making the buttons more prominent and the design of the components better.
    It would be easier to see the data of CI and the rest of the fleet by switching tabs.
    Example:
_2024_07_03_00_55_02_827.mp4

@fourinone41
Copy link
Contributor

Thanks. I've pushed some more terms:

  • autobonus_
  • event
  • bonus
  • sim_error
  • sim_warning

I still don't understand "vs LBAS".

Here is what I mean:
image
image

312 is "air power vs fleet"
318 is "air power vs LBAS" (because 6 extra comes from Tsu/He/Ri's recon planes)
I don't remember if "vs LBAS" has a reason to be useful for the player's fleet, if I confirm it's not used then perhaps it can be hidden when viewing player fleet's stats.

The following is not related to translation

Thank you for these suggestions, I will keep in mind for later.

When loading the composition, shouldn't it be loaded at the time the fleet type is selected?

Which part do you mean?

I think it would be better for users to know if the bonuses set in fleetSection are cumulative with bonuses set elsewhere, or if they are overwritten.

Personally I think in EN, "Override" is clear to mean "overwritten, not cumulative". It is also suggested by the UI here:
image
Do you think JP needs to add more components e.g. tooltip to explain properly?

"smokescreen_mods": "煙幕補正値",
"smoke_level": "煙幕レベル",
"activation_rate": "発動率",
// In Japanese, it is more natural to say "暫定計算式を使用する" (link to '暫定計算式')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean 暫定計算式を使用する (<a href="https://twitter.com/Xe_UCH/status/1767407602554855730">https://twitter.com/Xe_UCH/status/1767407602554855730</a>)? If so I can add another v-slot for direct link which only JP uses.
Or would this work?
"use_provisional_link": "暫定計算式を使用する ({link})",
"activation_formula": "<generic term such as 'Twitter'/'Link'>",

"set_bonuses": "手動セット",
"main_fleet_set": "Main Fleet set", // ?
"lbas_set": "Land Base Aerial Support set", // ?
"friend_fleet_set": "Friend Fleet set", // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Main Fleet set" means "Main Fleet bonuses have been set", to notify the user that they have already set some value. Same thing for the other two.
"lbas_set"/"friend_fleet_set" are currently unused but maybe I may find a use in the future.

"bonus_acc_desc": "マップ全体で命中ボーナスを付与します(倍率)",
"bonus_eva": "回避ボーナス",
"bonus_eva_desc": "マップ全体で回避ボーナスを付与します(倍率)",
// Who applies what to whom and how?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value is a damage multiplier similar to "Bonus Dmg" that is applied to the player ship's attack, it is effective against the enemy flagship of the final node only and is cumulative with Bonus Dmg.
Note this is a legacy setting to remain compatible with simulations done before we figured out precise debuff effects, so it would be rarely used now.

"aaci_none": "不発",
"aaci_planes": "固定ボーナス",
"aaci_rate": "発動率",
// For what?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet-wide AACI activation rate. For example, if Ship1 and Ship2 both have 50% individually but Ship1 has priority, then Ship1 -> 50%, Ship2 -> 25%.

"vs_installation_power": "対地火力",
"soft_skin": "ソフトスキン",
"pillbox": "砲台/トーチカ",
"iso_hime": "Iso Hime", // Who?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

離島棲姫

"diff_C": "丙",
"diff_D": "丁",
"hq_level": "司令部レベル",
"ff_skip_comps": "Skip comps with same ship in Main Fleet?", // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ON = If a Friend Fleet contains a ship which is also currently present in the player's Main Fleet, then do not import this Friend Fleet.

"from_friend_fleet": "From Friend Fleet", // ?
"from_targeting_boss": "From Targeting Boss", // ?
"import_to_main_fleet": "Import to Main Fleet", // ?
"import_to_friend_fleets": "Import to Friend Fleets", // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sorewachigauyo/kc-event-bonus/tree/master/54-5
"From Friend Fleet" = "Use the data where samples are from Friend Fleet attacking" (_friendlyfleet files)
"From Targeting Boss" = "Use the data where samples are from Enemy Flagship being attacked" (_vsboss files)

"Import to Main Fleet": ON = apply these bonus values to ships currently in the Main Fleet
"Import to Friend Fleets": ON = apply these bonus values to ships currently in the Friend Fleets

"request_error_not_found": "Request error/Not found", // ok
"request_timed_out": "Request timed out", // ok
"ship": "艦",
"count": "Count", // ?
Copy link
Contributor

@fourinone41 fourinone41 Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
These terms are from KCNav, perhaps they should match?
"max_low" "min_high" as well.

"average_all": "平均値を採用",
"confirm": "決定",

"warn_replay_import": "Warning: Replay import will overwrite existing data.", // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kc3kai.github.io/kancolle-replay/battleplayer.html From here, load a Sample Code and click IMPORT INTO SIMULATOR. It is a warning that data imported this way will replace whatever you had before.

"OASW": "先制対潜",
"CVCI": "昼戦空母CI",
"destroyerNBCI": "駆逐艦の夜戦CI",
"LBASBuff": "LBAS/Support Revamp (Fall 17)", // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting from Fall 2017 Event update, support and LBAS mechanics were updated to make them stronger: Support usable on night-only nodes, ASW support implemented, LBAS received bonus from proficiency, some calculation differences

"coloradoSpecialFix": "コロラドタッチ",
"eqBonusTorp": "艦攻に装備ボーナス適用",
"eqBonusASW": "対潜に装備ボーナス適用",
"ffReroll": "Friend Fleet Flagship Reroll", // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanic where Friend Fleet is less likely to target the enemy flagship. https://wikiwiki.jp/kancolle/%E5%8F%8B%E8%BB%8D%E8%89%A6%E9%9A%8A#notetext_3

"CVCI (BBA)": "空母CI (BBA)",
"CVCI (BA)": "空母CI (BA)",
"Zuiun CI": "海空立体攻撃/瑞雲立体攻撃",
"DB CI": "DB CI" // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wikiwiki.jp/kancolle/%E6%88%A6%E9%97%98%E3%81%AB%E3%81%A4%E3%81%84%E3%81%A6#Observation -> 詳細説明
"Sec. CI" = 主砲 + 副砲 (カットイン表示 column)
"Radar CI" = 主砲 + 電探
"AP+Sec. CI" = 主砲 + 徹甲弾
"AP CI" = 主砲 + 主砲
"Zuiun CI": 瑞雲立体攻撃 only? (only 瑞雲)
"DB CI" = 海空立体攻撃 only? (only 彗星(六三四空))

"NZuiun CI (ZZR)": "NZuiun CI (ZZR)", // ?
"NZuiun CI (ZZ)": "NZuiun CI (ZZ)", // ?
"NZuiun CI (ZR)": "NZuiun CI (ZR)", // ?
"NZuiun CI (Z)": "NZuiun CI (Z)" // ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wikiwiki.jp/kancolle/%E5%A4%9C%E6%88%A6#dfcb6e1f
"Mixed CI" = 魚魚主
"DDCI (GTR) x1" = 駆逐 主魚電
"DDCI (LTR) x1" = 駆逐 魚見電/魚水電
"DDCI (TTL) x1" = 駆逐 魚水魚
"DDCI (TDL) x1" = 駆逐 ド水魚
"... x2" = same as above, but versions that hit twice
"NZuiun CI (ZZR...)" = 主主瑞, Z = 試製 夜間瑞雲(攻撃装備), R = 電

"bug_reports_feature_requests": "バグ報告/要望",

// You can import your in-game fleet using KC3Kai's Basic Profile file.・・・
// I can't verify these because I don't have the environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are KC3 screenshots in JP mode (seems Profile Data currently untranslated):
image
image
image

"Strategy Room" = "戦闘指揮所"

"fuel_percent": "燃料残量(%)",
"ammo_percent": "弾薬残量(%)",
"air_sub_node": "対潜空襲マス",
"air_sub_support": "Support",// ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a short name for this node/setting, you can just name it "対潜空襲マス" if it fits.

@X-20A
Copy link
Author

X-20A commented Jul 3, 2024

jsonc has been removed because of the hassle of synchronization

  • Does "avg_resupply_tooltip" LBAS replenishment costs?
  • Does "standard_evasion_tooltip" mean the value for single-track?
  • Is it necessary to translate "change_logs"? I think it would be useful to check if the simulator is compatible with the new system implemented in the game.
  • kc3kai_import_desc_4_d" is probably fine as it is actually displayed as such in KC3 Kai, i.e. "kc3kai_import_desc_4" is fine.
    https://vaj.hatenablog.com/entry/kc3strategy1
  • I don't see "autobonus_off" to "autobonus_debuffed" in the html, what is the intended use?
  • Under what circumstances does "no_combinetype" appear?

Not related to translation

Why is the "air_sub_support" setting not in the Battle Type?

@fourinone41
Copy link
Contributor

Does "avg_resupply_tooltip" LBAS replenishment costs?

Yes, both sortie cost and replenishment cost are included for LBAS.

Does "standard_evasion_tooltip" mean the value for single-track?

Sorry not sure what you mean by "single-track". But "standard_evasion_tooltip" is the tooltip for explaining this: https://wikiwiki.jp/kancolle/%E5%91%BD%E4%B8%AD%E3%81%A8%E5%9B%9E%E9%81%BF%E3%81%AB%E3%81%A4%E3%81%84%E3%81%A6#avoidterm1
"Standard Evasion" = 基本回避項 = [陣形補正 * {素回避値 + 装備回避値 + √(2 * 運)}] but with 陣形補正 = 1 only

Is it necessary to translate "change_logs"? I think it would be useful to check if the simulator is compatible with the new system implemented in the game.

I just haven't implemented yet. But I am thinking about redesigning so it doesn't need <i18n-t> for links, since it may be updated often.

I don't see "autobonus_off" to "autobonus_debuffed" in the html, what is the intended use?

image
image

Under what circumstances does "no_combinetype" appear?

It's possible to send an input directly to sim, like this. So if that input is wrong, or if devs add new combined fleet type.

Why is the "air_sub_support" setting not in the Battle Type?

This is so you can set each enemy individually. If KC devs ever add something like non-carrier supporters, or non-submarine normal enemies, or night-only version, then it's already supported.
I guess you may be asking this because of "air_sub_support": "Support" term. Now that I think about it, it does not necessarily mean "Anti-Sub Air-Raid Node" specifically, but "the property of being treated as faraway" instead.

@X-20A
Copy link
Author

X-20A commented Jul 4, 2024

Personally I think in EN, "Override" is clear to mean "overwritten, not cumulative".

Okay, I can certainly see that it is an override.
I have a suggestion, if there is some kind of bonus setting, how about a note that the final setting can be found in the "Set Bonuses" for each node?

  • 'kc3kai_import_desc_4_b' was needed for the font weight, I made a mistake.
  • Regarding 'require_on_node', as far as I can tell, it is difficult to embed html elements(select&option) in i18n.
    I think we need two keys before and after to make it natural Japanese.
  • What is the 'max' setting?

@fourinone41
Copy link
Contributor

What is the 'max' setting?

There is a fixed maximum loss limit on maelstrom nodes.
https://wikiwiki.jp/kancolle/%E8%B3%87%E6%9D%90#b7c2f0c7 See 喪失量算出例2

@fourinone41
Copy link
Contributor

Found one missing term: "enemy_fleet": "Enemy Fleet",

image
Does this look OK? I think ダメージボーナス(ボス旗艦) may be a bit long? Since it is a rarely used outdated setting, I think it may be OK to have a shorter name (if there is one that works), and clarify more in the tooltip.

image
Is this correct? I wasn't sure because your simulator.html may have been bugged/incomplete.

@X-20A
Copy link
Author

X-20A commented Jul 4, 2024

There is a fixed maximum loss limit on maelstrom nodes.

Okay, but I don't think this is a widely known specification, so why not add a tooltip and write out the upper loss limit for each square there as well?

Found one missing term: "enemy_fleet": "Enemy Fleet",

"enemy_fleet": "敵艦隊"

Does this look OK? I think ダメージボーナス(ボス旗艦) may be a bit long? Since it is a rarely used outdated setting, I think it may be OK to have a shorter name (if there is one that works), and clarify more in the tooltip.

"ダメージボーナス(ボス旗艦)" can be shortened to "ボス特効".
In the tooltip, you can write "ボス旗艦へのダメージボーナス".

Is this correct? I wasn't sure because your simulator.html may have been bugged/incomplete.

Yes, the grammar is natural, but are we talking about coding?

I think it would be helpful to have a table that shows the correspondence between the English abbreviation and the Japanese notation for each ship type. I think it would be good to put a jp-wiki,en-wiki,Twitter but I don't know if the treatment in the simulator would match the table. For example, is the Souya divided into three types, or are they all supply ships together, etc.

@fourinone41
Copy link
Contributor

fourinone41 commented Jul 5, 2024

Okay, but I don't think this is a widely known specification, so why not add a tooltip and write out the upper loss limit for each square there as well?

Added "add_cost_max_tooltip"

"ダメージボーナス(ボス旗艦)" can be shortened to "ボス特効".
In the tooltip, you can write "ボス旗艦へのダメージボーナス".

Looks like similar wording is already there?
最終Nodeにおける敵旗艦へのダメージボーナス(倍率)。
I'll leave it to you to edit as necessary.

Yes, the grammar is natural, but are we talking about coding?

Just checking grammar, thanks.

I think it would be helpful to have a table that shows the correspondence between the English abbreviation and the Japanese notation for each ship type. I think it would be good to put a jp-wiki,en-wiki,Twitter but I don't know if the treatment in the simulator would match the table. For example, is the Souya divided into three types, or are they all supply ships together, etc.

They follow API types, the same as KCNav (so all Souya are AO, etc). I think many people may be familiar with them from using KCNav too.
image
Added "ship_counts_list"

Some questions:

image
UI is stretched here, any abbreviations possible? For example in EN it's CTF/STF/TCF.

image
Any shorter term? Can add tooltip if necessary.

image
How about this? Does it work grammar-wise?
Compared with before:
image

@X-20A
Copy link
Author

X-20A commented Jul 5, 2024

They follow API types, the same as KCNav (so all Souya are AO, etc). I think many people may be familiar with them from using KCNav too.

The goal is to understand the types of ships in self fleet, so perhaps we could approach it this way?
I think the tooltip is fine as it is.
Example:
キャプチャ_2024_07_06_02_33_18_519

How about this? Does it work grammar-wise?
Compared with before:

I think the layout is good.
特効:
ダメージ:
命中:
回避:
ボス旗艦:
It is natural to write

  • The 'add_cost_max' part can be written out as shown in the image, so you don't have to look it up every time, or you can probably type it in directly.

キャプチャ_2024_07_06_05_17_45_902

@fourinone41
Copy link
Contributor

Good ideas 👍 I've implemented both.

@X-20A
Copy link
Author

X-20A commented Jul 6, 2024

Thanks for adopting it. I think it looks really good.
I feel the attempts have reached the point of being up to par, what about you?

@fourinone41
Copy link
Contributor

Yep I think we are almost done.
Currently I am working on the change log, I will push that soon.
After that, I will do a full review to make sure everything is correct, I may have some questions.

@fourinone41
Copy link
Contributor

fourinone41 commented Jul 6, 2024

Added change log, can you look over those and add {link0} where needed?

A few questions to start:

Should the title (KanColle Sortie Simulator) be translated? Wondering if JP community already calls it "KanColle Sortie Simulator", for example.

image
Technically this is not "Node", but "Edge". KCNav calls it 航路, should it be that?
image

Also, "Node" is translated "マス" here (and on KCNav), but left untranslated elsewhere (like Node 1, Node 2 in Battles), just want to confirm, is that intentional?

image
Intentional that these are untranslated?

@fourinone41
Copy link
Contributor

"from_text": "デッキビルダーから",
This isn't only for Deckbuilder, but also simulator's own data format (which is for a single fleet only, and may contain things not in Deckbuilder such as bonus dmg/acc/eva).
I see it is mentioned in "from_text_note", but the primary use is for exporting + importing simulator's format, so I think it may be better to include that in "from_text".

"autoscale_stats": "自動調整 {img_hp}/{img_ev}/{img_asw}/{img_los} with {img_lv}",
"with" not translated, intentional?

"effective_los": "索敵値 (HQ120)",
HQ120 intentional? (FYI it means 艦隊司令部Lv.120)

"autobonus_off": "Off",
"autobonus_active": "Active",
"autobonus_preset": "Preset",
"autobonus_nodes": "Nodes",
"autobonus_node_default": "(default)",
Looks like these haven't been translated?

"CVCI": "昼戦空母CI",
This includes both day and night CVCI.

"kongouSpecialBuff": "僚艦夜戦突撃",
This is the 2021-08-04 update when Kongou Special was made stronger (can activate 2x per sortie, can activate alongside other Specials, ammo cost decreased). OFF = Kongou Special still possible, just without these changes.

"coloradoSpecialFix": "コロラドタッチ",
This is the 2022-06-18 update when Colorado Touch's was changed (can activate with chuuha 2nd/3rd ship, fixed a bug that allowed 5-slot ships to give their damage mods to the 3rd ship). OFF = Colorado Touch still possible, just without these changes.

The following are just to check if our understandings match (I am using machine translate, so apologies if these are due to bad machine translation):

"auto_set_bonus": "各Nodeへの史実ボーナスをまとめて設定",
"import_mapwide_bonuses_once": "マップ全体へのボーナスをまとめて設定",
"Auto-Set Historical Bonuses" is the newer feature and recommended if available. Its main purpose is to set each ship's bonus fields automatically (both in Fleets and Overrides) as you make changes to the fleet, although it may also be used similarly to "Import Bonuses Once" by turning it on with Apply to Current.
"Import Bonuses Once" is the older feature and is there for compatibility. The Mapwide button under "Historical Bonus:" sets the bonus fields in Fleets one time, and doesn't do anything else. The buttons in Battles sets the bonus fields in the Override one time, and doesn't do anything else.

"use_flat_evasion_bonus": "一律で適用",
"use_accuracy_multiplier": "個別に指定(倍率)",
"Use Flat Evasion Bonus" means to use the values below, which are fixed/flat values (based on an old vanguard evasion formula and is there for compatibility).
"Use Accuracy Multiplier" means to use the values below, which are multipliers (based on a newer vanguard formula and is recommended)

Can you confirm if these are being described accurately?

Also should have a change log entry for this update.
Would you like to be credited? We can also link to a page of your choice e.g. https://github.com/X-20A
"Added full JP UI translation (thanks to <a>X-20A</a>)"

@X-20A
Copy link
Author

X-20A commented Jul 6, 2024

Should the title (KanColle Sortie Simulator) be translated? Wondering if JP community already calls it "KanColle Sortie Simulator", for example.

Yes, that would be fine.

Technically this is not "Node", but "Edge". KCNav calls it 航路, should it be that?

I think neither 'edges' nor '航路' are very common in Japan.
I think there is no problem with 'select' and 'option' as they are used to select Node symbols.

Intentional that these are untranslated?

I have reviewed the parts that are still in English and everything is ok as it is. I think the translation into Japanese is not good, or to put it simply, it looks lame. However, it depends on my personal sensitivity, so I can't say for sure until I hear feedback.

Also should have a change log entry for this update.

Thanks, glad I could contribute.

@fourinone41
Copy link
Contributor

fourinone41 commented Jul 6, 2024

"apply_to_current_desc": "\u2610 All newly added ships starting now will have these bonuses as defaults.\n\u2611 Also apply these bonuses now to all currently set ships (Set: None = remove all).",
Before: "apply_to_current_desc": "\u2610 これから新しく追加されるすべての艦は、デフォルトでこれらのボーナスを付与されます。\n\u2611 また、これらのボーナスを現在設定されているすべての船に適用します。(ONにしない場合、全て削除)",
After: "apply_to_current_desc": "\u2611 現在の艦隊と、これから新しく追加される全ての艦はデフォルトでこれらのNodeにおける特効を付与されます。\n\u2610 (ONにしない場合、全て削除)",
I think this may have been more accurate before? It should mean:
OFF = All future ships in your fleet will have these bonuses by default, but current ships will be unaffected.
ON = All current and future ships in your fleet will have these bonuses by default. OR, if selected Set = None, then all current ships will have their bonuses removed (reset to 1).
image

Sorry found another one I missed: "fcf_settings_set": "FCF Settings set",
image

@fourinone41
Copy link
Contributor

One small thing, "Set: None removing all bonuses" happens only if it's ON. If it's OFF then current ships are unaffected just like otherwise. I moved that sentence to the first part, is that OK?
\u2611 ONの場合、現在の艦隊とこれから新しく追加される全ての艦はデフォルトでこれらのNodeにおける特効を付与されます。SetにNone を設定した場合、現在の全ての艦の特効が削除されます (1 にリセット)。\n
\u2610 OFFの場合、これから新しく追加される艦には適用されますが現在の艦には適用されません。

Besides that I think everything looks good.
May I contact you for translating updates in the future? Would here/#77 be a good way to reach you?

@X-20A
Copy link
Author

X-20A commented Jul 7, 2024

One small thing, "Set: None removing all bonuses" happens only if it's ON. If it's OFF then current ships are unaffected just like otherwise. I moved that sentence to the first part, is that OK?

I think it's good.I dare say that "(倍率: 1 にリセット)" would have been better than "(1 にリセット)".

May I contact you for translating updates in the future? Would here/#77 be a good way to reach you?

Yes, that's fine because the notification should come.I would like to cooperate unless unforeseen circumstances arise.

@fourinone41
Copy link
Contributor

fourinone41 commented Jul 7, 2024

Alright, glad to hear. 👍

I've published it to the site now. Thank you very much for your hard work. お疲れさまでした。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants