Fail CI if clazy fails

.github/workflows/build.yml

@@ -28,7 +28,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Install ninja-build tool
-        uses: turtlesec-no/get-ninja@main
+        uses: aseprite/get-ninja@main
 
       - name: Make sure MSVC is found when Ninja generator is in use
         uses: ilammy/msvc-dev-cmd@v1

CMakeLists.txt

@@ -40,6 +40,7 @@ include(FeatureSummary)
 option(${PROJECT_NAME}_TESTS "Build the tests" ON)
 option(${PROJECT_NAME}_EXAMPLES "Build the examples" ON)
 option(${PROJECT_NAME}_DOCS "Build the API documentation" OFF)
+option(${PROJECT_NAME}_ERROR_ON_WARNING "Enable all compiler warnings and treat them as errors" OFF)
 
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake)
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/ECM/modules)

CMakePresets.json

@@ -10,7 +10,8 @@
                 "CMAKE_BUILD_TYPE": "Debug",
                 "CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
                 "KDBindings_TESTS" : "ON",
-                "KDBindings_EXAMPLES" : "ON"
+                "KDBindings_EXAMPLES" : "ON",
+                "KDBindings_ERROR_ON_WARNING": "ON"
             }
         },
         {
@@ -23,7 +24,8 @@
                 "CMAKE_EXPORT_COMPILE_COMMANDS" : "ON",
                 "KDBindings_TESTS" : "ON",
                 "KDBindings_EXAMPLES" : "ON",
-                "KDBindings_DOCS" : "ON"
+                "KDBindings_DOCS" : "ON",
+                "KDBindings_ERROR_ON_WARNING": "ON"
             }
         },
         {
@@ -35,7 +37,8 @@
                 "CMAKE_BUILD_TYPE": "Debug",
                 "CMAKE_CXX_COMPILER" : "clazy",
                 "KDBindings_TESTS" : "ON",
-                "KDBindings_EXAMPLES" : "ON"
+                "KDBindings_EXAMPLES" : "ON",
+                "KDBindings_ERROR_ON_WARNING" : "ON"
             },
             "warnings": {
                 "uninitialized": true
@@ -94,6 +97,12 @@
             "configurePreset": "dev",
             "output": {"outputOnFailure": true},
             "execution": {"noTestsAction": "error", "stopOnFailure": false}
+        },
+        {
+            "name": "clazy",
+            "configurePreset": "clazy",
+            "output": {"outputOnFailure": true},
+            "execution": {"noTestsAction": "error", "stopOnFailure": false}
         }
     ]
 }

src/kdbindings/CMakeLists.txt

@@ -37,6 +37,13 @@ target_include_directories(KDBindings INTERFACE
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/..>
   $<INSTALL_INTERFACE:include>
 )
+if(KDBindings_ERROR_ON_WARNING)
+  if(MSVC)
+    target_compile_options(KDBindings INTERFACE /W3 /WX)
+  else()
+    target_compile_options(KDBindings INTERFACE -Wall -Wextra -Wpedantic -Werror)
+  endif()
+endif()
 
 # Generate library version files
 include(ECMSetupVersion)

tests/binding/tst_binding.cpp

@@ -22,6 +22,10 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include <doctest.h>
 
+// The expansion of TEST_CASE from doctest leads to a clazy warning.
+// As this issue originates from doctest, disable the warning.
+// clazy:excludeall=non-pod-global-static
+
 using namespace KDBindings;
 
 static_assert(std::is_destructible<Binding<int>>{});

tests/node/tst_node.cpp

@@ -19,6 +19,10 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include <doctest.h>
 
+// The expansion of TEST_CASE from doctest leads to a clazy warning.
+// As this issue originates from doctest, disable the warning.
+// clazy:excludeall=non-pod-global-static
+
 using namespace KDBindings;
 
 static_assert(std::is_destructible<Private::NodeInterface<float>>{});
@@ -404,15 +408,14 @@ TEST_CASE("bindable_value_type and operator_node")
         REQUIRE(node2.evaluate() == (OP(OP(VALUE))));   \
     }
 
-TEST_CASE("Test unary operators")
-{
+TEST_CASE("Test unary operators"){
     KDBINDINGS_UNARY_OPERATOR_TEST(!, bool, true)
 
-    KDBINDINGS_UNARY_OPERATOR_TEST(~, uint8_t, 25)
+            KDBINDINGS_UNARY_OPERATOR_TEST(~, uint8_t, 25)
 
-    KDBINDINGS_UNARY_OPERATOR_TEST(+, int, -10)
+                    KDBINDINGS_UNARY_OPERATOR_TEST(+, int, -10)
 
-    KDBINDINGS_UNARY_OPERATOR_TEST(-, int, 10)
+                            KDBINDINGS_UNARY_OPERATOR_TEST(-, int, 10)
 }
 
 #define KDBINDINGS_BINARY_OPERATOR_TEST(OP, TYPE, VALUE, OTHER)     \

tests/property/tst_property.cpp

@@ -16,6 +16,10 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include <doctest.h>
 
+// The expansion of TEST_CASE from doctest leads to a clazy warning.
+// As this issue originates from doctest, disable the warning.
+// clazy:excludeall=non-pod-global-static
+
 using namespace KDBindings;
 
 static_assert(std::is_nothrow_destructible<Property<int>>{});

tests/signal/tst_signal.cpp

@@ -20,6 +20,10 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include <doctest.h>
 
+// The expansion of TEST_CASE from doctest leads to a clazy warning.
+// As this issue originates from doctest, disable the warning.
+// clazy:excludeall=non-pod-global-static
+
 using namespace KDBindings;
 
 static_assert(std::is_nothrow_destructible<Signal<int>>{});

tests/utils/tst_gen_index_array.cpp

@@ -15,6 +15,10 @@
 
 #include <doctest.h>
 
+// The expansion of TEST_CASE from doctest leads to a clazy warning.
+// As this issue originates from doctest, disable the warning.
+// clazy:excludeall=non-pod-global-static
+
 using namespace KDBindings::Private;
 
 static_assert(std::is_nothrow_destructible<GenerationalIndexArray<int>>{});