Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump jurplel/install-qt-action from 3 to 4 #1080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024

Bumps jurplel/install-qt-action from 3 to 4.

Release notes

Sourced from jurplel/install-qt-action's releases.

install-qt-action v4.0.0

The biggest change with this version is aqtinstall being updated to 3.1. Most of the other changes are from PRs listed below. The reason this is 4.0.0 is due to (relatively small) breaking changes from the PRs annotated with [v4]. Consult the upgrade guide for details on breaking changes.

Auto-generated list of PRs:

A big thanks to everyone involved for their contributions to the project, and a special thanks to those who have been helping to manage the Github issues.

install-qt-action v3.3.0

install-qt-action v3.2.1

  • add back automatic libxkbcommon-x11-0 installation on linux

install-qt-action v3.2.0

install-qt-action v3.1.0

  • Fix detection of Qt architecture directory thanks to @​ddalcino
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3bd62ab) to head (bbc1fca).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1080   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11928     11928           
=========================================
  Hits         11928     11928           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahayzen-kdab
Copy link
Collaborator

@mattkdab with the new version of install-qt-action it states this for version 4.

Use the --autodesktop flag to automatically install the desktop version of Qt, parallel to any WASM or mobile versions of Qt 6.2 and above.

If your action installed Qt 6.2+ for Android or WASM using install-qt-action@v3, then your action would have needed to install the desktop version of Qt alongside the WASM/mobile version of Qt, otherwise it would not have worked properly. As long as you are using aqtinstall v3 or higher, the new version of install-qt-action will do that automatically, so you can remove the second step where you add the parallel desktop version of Qt. If you don't, your workflow will install desktop Qt twice.

https://github.com/jurplel/install-qt-action/blob/master/README_upgrade_guide.md

Sounds like we might be able to only have one block and not the gcc + wasm block now ?

Bumps [jurplel/install-qt-action](https://github.com/jurplel/install-qt-action) from 3 to 4.
- [Release notes](https://github.com/jurplel/install-qt-action/releases)
- [Commits](jurplel/install-qt-action@v3...v4)

---
updated-dependencies:
- dependency-name: jurplel/install-qt-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/jurplel/install-qt-action-4 branch from 4f67d63 to bbc1fca Compare October 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant