WIP: cxx-qt-gen: add checks phase #213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
add-checks-phase
branch
from
8b26881
to
5a0fc44
Compare
|
This needs more thought around how it can figure out the names, probably will be combined with the generator phase refactor. As it needs to know how the case conversion is done, the names of generated methods, wrappers etc. |
|
Is this still relevant? |
Potentially, when improving the error messages from the macro expansion in the next cycles, we need to consider if there are errors we need to detect and emit vs leaving them up to the compiler. A checks phase like CXX was the idea for that ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.