-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: examples: create a multi project to test multiple crates #598
base: main
Are you sure you want to change the base?
Conversation
Blocked on rust-lang/rust#108081 |
b3a1337
to
4f929ab
Compare
Upstream PR to make this work: rust-lang/rust#113301 |
a402176
to
5979009
Compare
The upstream PR has been merged and will be released in stable Rust 1.74, which is scheduled for 16 November 2023. I suggest to leave this as a draft until then. |
@Be-ing Awesome news, thanks! :-) |
Rust 1.74 has been released so this now builds with stable Rust! 🥳 |
@Be-ing sweet! Great work on getting that stabilised into Rust 💪 We look at getting this landed and the reshuffle internally in the next cycle I think as 0.6 is imminent with a deadline we need to reach. |
5979009
to
aac8317
Compare
Seems to be getting a linking issue with double resources, need to investigate. Wonder if it's the QML module changes. |
Fixed in #755 |
aac8317
to
b144bd0
Compare
Locally this builds now, but it fails to run as it can't find the sub QML QObjects, needs some further investigation or maybe a clean build. |
I can reproduce that. |
I opened a PR for your fork to get this working: ahayzen-kdab#4 The errors were simply from missing |
Aha! great spot thanks! |
29127a1
to
2420d45
Compare
Seems macOS works, Windows has had a wobble with file locking / mapped stuff, Linux explodes using ld.gold. Is this one of those, only lld works situations ? |
Seems we're continuing the CXX-Qt tradition of stumbling over the weirdest edge cases of toolchains 😅 Somehow Cargo does specify linking the same qt-static-initializers library twice with As for the Windows Qt5 build error:
I don't know. Another cargo/rustc bug? A Windows bug? I don't see this error code anywhere in any rust-lang GitHub repositories. A quick hack around both of these problems would be replacing the |
😅 Yeah, a switch around to ensure it builds (and maybe runs) would be useful, I'll probably look into this next month as I'm tight on time. |
I don't think it's worth deep diving into the root causes of these errors right now considering that qml-meta-project doesn't even have Cargo tests. So I think switching to |
Hopefully this will be enough to merge finally: ahayzen-kdab#5 |
Otherwise we have a build failure as qmlcache_loader.cpp file does not exist.
rlibs are the default for library crates; no need to specify that explicitly.
The `increment` methods of the subobjects are invoked from QML, so don't also invoke them from Rust. This also makes the behavior of the application clearer: Main counts by 1, Sub1 counts by 2, Sub2 counts by 3.
This isn't required for the libraries published to crates.io, so this isn't specified in the workspace Cargo.toml.
No need to change the privacy of these; just need to have the symbols referenced within the staticlib crate.
77ced1f
to
db75055
Compare
to avoid linking failures as described in comment
db75055
to
3f47566
Compare
Split only running cachegen when there are QML files in #811 |
Wonder if it's the Rust side that needs to not be parallel rather than the C++/CMake side, but still shouldn't happen. |
No description provided.