Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QByteArrayCursor #741

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

QByteArrayCursor #741

wants to merge 2 commits into from

Conversation

LeonMatthesKDAB
Copy link
Collaborator

This is similar to Rusts Cursor type.
It allows access to a QByteArray through the Write + Seek traits.
This is quite useful for interaction with the wider Rust ecosystem.

@LeonMatthesKDAB
Add minimal implementation of QImage
e42e95a 
Just enough to make the qt-tutorial for KDAB training day work
@LeonMatthesKDAB
Add QByteArrayCursor
c6a7096 
This is similar to Rusts Cursor<T> type.
It allows access to a QByteArray through the `Write` + `Seek` traits.
This is quite useful for interaction with the wider Rust ecosystem.
LeonMatthesKDAB
LeonMatthesKDAB commented Nov 17, 2023
View reviewed changes
crates/cxx-qt-lib/src/core/qbytearray.rs

/// Like the implementation of `Cursor<Vec<u8>>`, the QByteArrayCursor
/// will overwrite existing data in the QByteArray.
/// The QByteArray is resized as needed.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this doc go on the impl or on the fn ? does it work in a cargo doc ?

@LeonMatthesKDAB LeonMatthesKDAB mentioned this pull request Nov 17, 2023
Merged
@LeonMatthesKDAB
Copy link
Collaborator Author

LeonMatthesKDAB commented Dec 15, 2023 •
edited
Loading

@ahayzen-kdab @Montel I'm wondering whether we should just abandon this PR.
It's useful, yes, but also something that users could easily add themselves.
If we want to support this, I think it can go into cxx-qt-lib-extra, as it's a bit of a maintenance burden.

Any opinions?

@LeonMatthesKDAB
Copy link
Collaborator Author

See also: #766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LeonMatthesKDAB