Fix/post #20
Merged
Fix/post #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code runs great and didn't needed lot of changes. Therefore i have tried my best to improve the performance and error handling of the code. - Removed "comments" field as not needed anymore - Added @notblank and @NotNull annotations to ensure that title, content, and user are always provided. - Added fetch = FetchType.LAZY to the User relationship to improve performance by loading user data only when needed.
- Added a method findByTag to retrieve posts by tag directly from the database (Improve Memory efficiency) The method helps further in PostService.java code.
- Using findByTag method directly in getPostsByTag to improve efficiency. - Added a custom exception (RuntimeException) to handle cases where a post is not found. - Added @transactional annotation to updatePost and deletePost methods to ensure proper data management.
|
javax.validation.constraints package가 존재하지 않는다고 하니 확인 부탁드립니다. |
17cafdb |
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code works great and there weren't many necessary issues to be corrected but i have tried my best to make it more efficient and readable.
Thank you, Looking forward to any suggestions.