Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SM fakefactor functions, improve performance of nmssm functions #219

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

harrypuuter
Copy link
Member

No description provided.

@harrypuuter harrypuuter marked this pull request as ready for review August 31, 2023 13:34
->at("QCD_non_closure_lep_pt_correction");
auto qcd_lep_iso_closure =
correction::CorrectionSet::from_file(ff_corr_file)
->at("QCD_non_closure_lep_iso_correction");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I renamed some of the corrections in the FF framework (latest commit) this might not be correct anymore. (this also applies for other corrections).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to the naming changes ? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can look at this dict here https://github.com/nshadskiy/TauFakeFactors/blob/main/helper/correctionlib_json.py#L8-L25
I basically added leading or subleading to the naming corresponding to first and second lepton (e, mu, tau). I think I did it like this because it was easier to be consistent in the tt channel.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be save you can look at the summary of the correctionlib files you are using. It just has to be consistent with the naming there.

@harrypuuter harrypuuter marked this pull request as draft February 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants