Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#913 fix statusled extension variable name typo #914

Merged
merged 3 commits into from
Nov 18, 2023
Merged

#913 fix statusled extension variable name typo #914

merged 3 commits into from
Nov 18, 2023

Conversation

minordemon
Copy link
Contributor

Fix for issue 913.

Renamed self._brightness to self.brightness

xs5871
xs5871 requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github changed something in the UI and I can't review individual code segments and suggest changes anymore. Very cool.
Line 64: There's one missed _brightness that needs renaming.

xs5871
xs5871 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@minordemon
Copy link
Contributor Author

Wow, I failed at doing a replace all..

Thanks for checking.

@xs5871 xs5871 merged commit e7b0c0e into KMKfw:master Nov 18, 2023
1 check passed
@xs5871 xs5871 mentioned this pull request Dec 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xs5871 xs5871 xs5871 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minordemon @xs5871