Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to use different coefficients for different boundaries when using the Robin boundary condition.
More specifically,
k_s
andc_s
as a list even when there’s one boundary with Robin boundary condition.k_s[i]
andc_s[i]
for the boundaryds_s_id[i]
. For example, if you have two boundary with ID 10, 20, to which you want to apply the Robin boundary condition. Then, you want to usek_s=10
c_s=100
for ID=10 andk_s=20
c_s=200
for ID=20. Then you should definedds_s_id = [10, 20]
k_s = [10, 20]
c_s = [100, 200]
.Additionally, there are some modifications to the problem file
RobinBC_validation
so that it works with new syntax.