Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple robin #108

Merged
merged 3 commits into from
May 23, 2024
Merged

Multiple robin #108

merged 3 commits into from
May 23, 2024

Conversation

keiyamamo
Copy link
Collaborator

This PR adds functionality to use different coefficients for different boundaries when using the Robin boundary condition.

More specifically,

  • We should now define k_s and c_s as a list even when there’s one boundary with Robin boundary condition.
  • turtleFSI will use k_s[i] and c_s[i] for the boundary ds_s_id[i]. For example, if you have two boundary with ID 10, 20, to which you want to apply the Robin boundary condition. Then, you want to use k_s=10 c_s=100 for ID=10 and k_s=20 c_s=200 for ID=20. Then you should defined ds_s_id = [10, 20] k_s = [10, 20] c_s = [100, 200].

Additionally, there are some modifications to the problem file RobinBC_validation so that it works with new syntax.

@keiyamamo keiyamamo requested a review from johannesring May 22, 2024 10:44
Copy link
Collaborator

@johannesring johannesring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keiyamamo keiyamamo merged commit 80c9a08 into KVSlab:master May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants