Add no_ns variants for Node and RoNode methods #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes what started in another PR by adding the node methods
has_property_no_ns
,remove_property_no_ns
andget_property_node_no_ns
. These methods target nonprefixed properties and are needed when an element has multiple properties with the same local name, as in the example below:Also, the method
get_property_node_ns
was added.There was no added functionality to be gained by introducing
set_property_no_ns
as the existing methodset_property
sets the value for an attribute with no namespace.While this adds functionality, it seems too verbose and repetitive. More ideally, one should have two variants of each method. One only takes an attribute name and does not consider namespaces:
The other takes an attribute name and, optionally, a namespace name:
However, this will introduce braking changes for
has_property_ns
,get_property_ns
andremove_property_ns
. Could this be considered now?