KOSP => KOSU #54
Merged
KOSP => KOSU #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andressbarajas
commented
Dec 10, 2024
andressbarajas
commented
- Update byteorder to not rely on arch types
- Fix wide character support
- Correct out-of-memory test in scandir
- Reverse the order of searching the genwait queue
byteorder.h was including <sys/_types.h> taking advantage of an old workaround that exports our internal types through that header and into stdio. This was the only file relying on that workaround in the KOS codebase and adjusting it is needed for #840
The previous cleanup of bfont.h accidentally used the size of a thin char to calculate the offsets for all the wide chars. The impact was visible in the bfont example where instead of printing the start button icon, a JISX-0208 character was printed.
The test after realloc was improperly testing 'list' for NULL rather than '*list'.
This should provide an optimization for the more common scenario of new entries waiting longer than old.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.