Add support for the following HSL syntax #900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsl(360 50% 50%) hsl(360deg 50% 50%) hsl(360deg, 50%, 50%) Note: The legacy hsla() syntax is an alias for hsl(), accepting the same parameters and behaving in the same way. Source: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/hsl So hsla regex should be removed IMO.
|
@KamiKillertO you think you have some time to check this PR? 🙂 |
|
@spacecat Can you add some tests? |
|
Sorry, life caught up with me.. been and am very busy so won't be able to create tests in a while if ever... :( I hope someone else can find some time to do it or create an entirely new PR. |
|
I've just merged a PR that add partial for the new syntax while keeping support for legacy one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following HSL syntax:
hsl(360 50% 50%)
hsl(360deg 50% 50%)
hsl(360deg, 50%, 50%)
Note: The legacy hsla() syntax is an alias for hsl(), accepting the same parameters and behaving in the same way.
Source: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/hsl
So hsla regex should be removed IMO.