Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SETTING] 설정 파일 수정 #199

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[SETTING] 설정 파일 수정 #199

merged 2 commits into from
Nov 8, 2023

Conversation

unanchoi
Copy link
Contributor

@unanchoi unanchoi commented Nov 8, 2023

📝 Summary

설정 파일을 수정했습니다.

👩‍💻 Contents

  • application.yml에서 노출시키지 않을 값들을 따로 분리했습니다.
  • application-secret.properties에서 해당 값들을 관리합니다.

📝 Review Note

  • EC2에는 파일을 직접 넣도록 하겠습니다.

📣 Related Issue

📬 Reference

@unanchoi unanchoi self-assigned this Nov 8, 2023
@unanchoi unanchoi force-pushed the setting/#197/resources branch from 51c7b99 to e7c3058 Compare November 8, 2023 15:37
Seokyeong237
Seokyeong237 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Seokyeong237 Seokyeong237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@unanchoi unanchoi merged commit 25aab41 into develop Nov 8, 2023
1 check passed
@unanchoi unanchoi deleted the setting/#197/resources branch November 8, 2023 17:22
@unanchoi
Copy link
Contributor Author

unanchoi commented Nov 8, 2023

close #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seokyeong237 Seokyeong237 Seokyeong237 approved these changes

@yeseul106 yeseul106 Awaiting requested review from yeseul106

Assignees

@unanchoi unanchoi

Labels
⚙️Config⚙️ 🐻 윤한 🐻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SETTING] 설정 파일 수정
2 participants
@unanchoi @Seokyeong237