Fail deployment if instance refresh fails #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloydwatkin
force-pushed
the
exit-if-failed
branch
from
fca63f2
to
567f8a4
Compare
ppostma
reviewed
Jul 5, 2024
ppostma
reviewed
Jul 10, 2024
|
Any update on this @ppostma ? Thanks! |
|
Sorry holidays... ;-) All good now, I'll try to prepare a new release in the upcoming days. |
|
Thanks! Hope you had a good break :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an instance refresh completes with a status of "Failed" the deployment still gets marked as successful.
This change raises an error if one (or more) of the autoscaling group refreshes fails.