Add support for float16 to HIP backend #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
While I think this PR is good, I am pretty sure that the HIP backend does not need to know the dtype of the arguments. It can just directly copy the bytes from the numpy array onto the GPU without looking at the data type. The pycuda backend does the same. I'm not sure why this check on the dtype exists in the first place. |
|
Good point Stijn! I propose we merge this and then open an issue to discuss removing the check. |
benvanwerkhoven
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HIP backend failed with float16 numpy arrays as input. This is fixed by adding a float16 entry to the dtype map. ctypes does not have float16, but it is fine to use another type of the same size so I opted for int16.
Additionally, I have added myself to the Kernel Tuner author list as discussed with Ben.