Fix: allow reordering pinned columns

[knissley]

I noticed that while having enableColumnOrdering, enableColumnPinning, and enableColumnDragging enabled the reorder action didn't impact the order of the pinned columns from either the drag handle or from the columns menu.

Example:

column-pin-reordering.mov

I had two approaches in mind to fix this

• Add a setState change in the event handler for MRT_TableHeadCellGrabHandle and MRT_ShowHideColumnsMenuItems to reorder the pins where appropriate (columns are able to pin and are pinned)
• Add some logic within TanStack table which reconciles column ordering and column pins so that both pinning positions reflect the same column id order as in the column order state.

I thought the second approach might be more appropriate to ensure this behavior works across other potential reorder actions, and so that the aforementioned components can remain simpler and just continue to call setColumnOrder.

However I wasn't able to find the best place in TanStack Table's source code to address this, so I opted to make the change seen in this PR. I'm very open to figuring out the change in TanStack if you agree that's a better place to fix it, and especially if you have some pointers on where I might look to investigate this behavior there.

An example, with this change applied:

column-pin-reordering-fix.mov

I opted to not run this reordering when an unpinned column is dragged into the pinned column area, maintaining that action as just a form of calling pin on the column.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
material-react-table	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2024 9:27pm
material-react-table-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2024 9:27pm

[KevinVandy]

There seems to be a lot of redundant code here. I think they're has to be a simpler way to implement this. Every kb of code kinda matters here. Is a whole new reorderColumnPinning function necessary?