Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double highlight nested tables #1197

Closed
wants to merge 2 commits into from
Closed

Don't double highlight nested tables #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f0f4b
Don't double highlight nested tables
Jul 23, 2024
ba73829
Merge branch 'KevinVandy:v2' into nested-td-bg
ryanmk54 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/material-react-table/src/components/body/MRT_TableBodyRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export const MRT_TableBodyRow = <TData extends MRT_RowData>({
...tableRowProps?.style,
}}
sx={(theme: Theme) => ({
'&:hover td:after': cellHighlightColorHover
'&:hover > td:after': cellHighlightColorHover
? {
backgroundColor: alpha(cellHighlightColorHover, 0.3),
...commonCellBeforeAfterStyles,
Expand Down
10 changes: 10 additions & 0 deletions packages/material-react-table/stories/styling/TableBodyRowStyles.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,18 @@ const columns: MRT_ColumnDef<(typeof data)[0]>[] = [
{
accessorKey: 'address',
header: 'Address',
Cell: ({ cell }) => (
<table>
<tbody>
<tr>
<td>{cell.getValue<string>()}</td>
</tr>
</tbody>
</table>
)
},
];

const data = [...Array(21)].map(() => ({
address: faker.location.streetAddress(),
age: faker.number.int(80),
Expand Down
Loading