fix: #718 dragend don't fire on virtualization #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm new to github actions, can somebody tell me why it when wrong at Checkout Repository step? What should I do? |
KevinVandy
requested changes
Oct 9, 2023
| @@ -146,6 +149,15 @@ export const MRT_TableBody = <TData extends Record<string, any>>({ | |||
| rowPinning, | |||
| ]); | |||
|
|
|||
| const draggingRowIndex = rows.findIndex((row) => row.id === draggingRow?.id); | |||
There was a problem hiding this comment.
this might introduce some performance overhead
| @@ -93,6 +94,10 @@ export const MRT_Table = <TData extends Record<string, any>>({ | |||
| [columnPinning, enableColumnVirtualization, enableColumnPinning], | |||
| ); | |||
|
|
|||
| const draggingColumnIndex = table | |||
| .getVisibleLeafColumns() | |||
| .findIndex((c) => c.id === draggingColumn?.id); | |||
There was a problem hiding this comment.
Another scanning of all rows potentially on every render, even if no dragging is occurring or the dragging features are not enabled
KevinVandy
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#718
use
rangeExtractorto keepdraggingRowordraggingColumnin document.